Skip to content

fix: expose missing public modifiers in Imperial units #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devhebert wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: expose missing public modifiers in Imperial units #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6556687
fix: expose missing public modifiers in Imperial units
devhebert Mar 19, 2026
b2c4374
fix: expose missing public modifiers in Imperial units
devhebert Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions common/src/main/java/systems/uom/common/Imperial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,15 @@ public final class Imperial extends AbstractSystemOfUnits {
* A unit of temperature equal to <code>5/9 °K</code> (standard name
* <code>°R</code>).
*/
static final Unit<Temperature> RANKINE = addUnit(KELVIN.multiply(5).divide(9), "Rankine", "°R", true);
public static final Unit<Temperature> RANKINE = addUnit(KELVIN.multiply(5).divide(9), "Rankine", "°R", true);

/**
* A unit of temperature equal to degree Rankine minus
* <code>459.67 °R</code> (standard name <code>°F</code>).
*
* @see #RANKINE
*/
static final Unit<Temperature> FAHRENHEIT = addUnit(RANKINE.shift(459.67), "°F", true);
public static final Unit<Temperature> FAHRENHEIT = addUnit(RANKINE.shift(459.67), "°F", true);

//////////////
// Time //
Expand All @@ -151,13 +151,13 @@ public final class Imperial extends AbstractSystemOfUnits {
* A unit of time equal to <code>60 s</code> (standard name <code>min</code>
* ).
*/
static final Unit<Time> MINUTE = addUnit(SECOND.multiply(60));
public static final Unit<Time> MINUTE = addUnit(SECOND.multiply(60));

/**
* A unit of duration equal to <code>60 {@link #MINUTE}</code> (standard
* name <code>h</code>).
*/
static final Unit<Time> HOUR = addUnit(MINUTE.multiply(60));
public static final Unit<Time> HOUR = addUnit(MINUTE.multiply(60));

//////////
// Area //
Expand Down Expand Up @@ -198,7 +198,7 @@ public final class Imperial extends AbstractSystemOfUnits {
* A unit of volume equal to <code>1 / 160 {@link #GALLON_UK}</code>
* (standard name <code>fl_oz_uk</code>).
*/
static final Unit<Volume> FLUID_OUNCE_UK = GALLON_UK.divide(160);
public static final Unit<Volume> FLUID_OUNCE_UK = GALLON_UK.divide(160);

/**
* A unit of volume equal to <code>1 / 160 {@link #GALLON_LIQUID}</code>
Expand Down