chore: harden release — green suite, lint 0, ANSI unification (INT-2271, INT-2260) (#190)

* test(service): fix stale provider-override boot tests + harden release (INT-2271)

The 2 failing service.test.ts tests were stale, not a regression: the provider-
override reapply lives inside the `if (config.autonomous?.enabled)` block (it
calls runnerInstance.switchProvider, which needs a runner), but the tests drove
it with a non-autonomous config — one spread `mockConfig.autonomous` (undefined
→ {}), the other asserted readProviderOverride on a plain boot.

- 'reapplies override on boot' now uses mockAutonomousConfig (+ adapter override).
- 'initialize all required modules' drops the autonomous-only readProviderOverride
  assertion (the reapply is covered by the two override-specific tests).
- service.test.ts: 37/37 green.

Also harden the release pipeline now that the suite is green:
- package.json: postbuild `chmod +x dist/cli.js` — a clean `rm -rf dist && build`
  otherwise drops the exec bit and the global CLI hits "permission denied".
- ci.yml: promote the test job to a hard gate (drop continue-on-error).

* refactor: clean all lint warnings + finish ANSI unification (INT-2260, INT-2270)

Now that the suite is green, make lint meaningful and finish the status-color
consistency work so the hard CI/release gates hold.

Lint (36 warnings → 0):
- Remove unused imports / variables across 11 files (issues bridges, discordCore,
  chatMemory, scanner's recursion-only param, cli.ts self-registering command
  binding, several test files).
- Prefix intentionally-unused mock params with `_`; disable no-control-regex on
  the ANSI-stripping regex; two endsWith() swaps in bsDetector.

ANSI unification (checkHandler.ts):
- Replace the file's hand-rolled always-on ANSI `c` map (~108 call sites) with the
  shared NO_COLOR/TTY-safe helper from src/support/colors — `c.green('x')` +
  `status.ok/err/warn/glyph` where a status glyph fits. Non-status badges keep
  their glyph. Output is byte-identical under non-TTY, so substring tests hold.

Full suite now green: typecheck / build / lint (0 warnings) / test (1306 passed).

Author: unohee

.github/workflows/ci.yml

@@ -69,7 +69,6 @@ jobs:
           cache: 'npm'
       - run: npm ci
       - run: npm test
-        continue-on-error: true
 
   loc-gate:
     name: LOC Warning (800 lines)

package.json

@@ -20,6 +20,7 @@
     "dev": "node --env-file=.env --import=tsx src/index.ts",
     "prestart": "pkill -f 'dist/index.js' 2>/dev/null || true",
     "build": "tsc",
+    "postbuild": "chmod +x dist/cli.js",
     "start": "node --env-file=.env dist/index.js",
     "stop": "pkill -f 'node --env-file=.env.*openswarm' 2>/dev/null || echo 'No process running'",
     "lint": "oxlint src/",

src/automation/longRunningMonitor.ts

@@ -45,6 +45,7 @@ function safeCompileRegex(pattern: string | undefined): RegExp | null {
 // Argv validation: reject null bytes, newlines, and other control chars.
 // Because we never spawn a shell, shell metacharacters are inert — only
 // control characters meaningfully change behavior (e.g. null byte truncation).
+// eslint-disable-next-line no-control-regex
 const ARGV_SAFE = /^[^\x00-\x1F\x7F]+$/;
 
 // Program allowlist for monitor checks. Anything outside this list — or any

src/cli.ts

@@ -513,7 +513,7 @@ program
 
 // openswarm check annotate <qualifiedName>
 
-const checkAnnotate = program
+program
   .command('annotate')
   .description('Annotate a code entity in the registry')
   .argument('<qualifiedName>', 'Entity qualified name (file::name) or search term')

src/cli/checkHandler.ts

@@ -1,13 +1,11 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import { existsSync, readFileSync, writeFileSync } from 'node:fs';
-import { join } from 'node:path';
+import { existsSync, readFileSync } from 'node:fs';
 import { homedir } from 'node:os';
 import {
   loadConfig,
   validateConfig,
   createAgentSession,
   generateSampleConfig,
-  type RawConfig,
 } from './config.js';
 import * as fs from 'node:fs';
 
@@ -22,8 +20,6 @@ vi.mock('node:fs', async () => {
 });
 
 describe('config', () => {
-  const testDir = '/tmp/test-config';
-
   beforeEach(() => {
     vi.clearAllMocks();
     process.env.DISCORD_TOKEN = 'test-discord-token';
@@ -69,7 +65,7 @@ agents:
         expect(config).toBeDefined();
         expect(config.agents).toHaveLength(1);
         expect(config.agents[0].name).toBe('main');
-      } catch (err) {
+      } catch {
         // YAML parsing might fail in test environment, but we're testing the function exists
       }
     });
@@ -102,7 +98,7 @@ agents:
         const config = loadConfig('/tmp/config.json');
         expect(config).toBeDefined();
         expect(config.agents).toHaveLength(1);
-      } catch (err) {
+      } catch {
         // JSON parsing might fail in test environment
       }
     });
@@ -257,7 +253,7 @@ agents:
         const config = loadConfig('/tmp/config.yaml');
         // Path should be expanded
         expect(config.agents[0].projectPath).toContain(homedir());
-      } catch (err) {
+      } catch {
         // Might fail due to YAML parsing or validation
       }
     });
@@ -293,7 +289,7 @@ agents:
         const config = loadConfig('/tmp/config.yaml');
         // After substitution, token should be replaced
         expect(config.discordToken).toBeDefined();
-      } catch (err) {
+      } catch {
         // Validation might fail but substitution happened
       }
 
@@ -323,7 +319,7 @@ agents:
         const config = loadConfig('/tmp/config.yaml');
         // Should use default value
         expect(config.discordToken).toBeDefined();
-      } catch (err) {
+      } catch {
         // Validation might fail
       }
     });
@@ -678,7 +674,7 @@ agents:
         // Defaults should be applied
         expect(config.agents[0].enabled).toBe(true);
         expect(config.agents[0].paused).toBe(false);
-      } catch (err) {
+      } catch {
         // Validation might fail
       }
     });
@@ -713,7 +709,7 @@ agents:
       try {
         const config = loadConfig('/tmp/config.yaml');
         expect(config.githubRepos).toEqual(['owner/repo1', 'owner/repo2']);
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });
@@ -739,7 +735,7 @@ agents:
         const config = loadConfig('/tmp/config.yaml');
         // Should have default heartbeat interval
         expect(config.defaultHeartbeatInterval).toBeGreaterThan(0);
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });
@@ -770,7 +766,7 @@ agents:
       try {
         const config = loadConfig('/tmp/config.yaml');
         expect(config).toBeDefined();
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });
@@ -796,7 +792,7 @@ agents:
       try {
         const config = loadConfig('/tmp/config.yaml');
         expect(config.discordToken.length).toBeGreaterThan(500);
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });
@@ -824,7 +820,7 @@ agents:
       try {
         const config = loadConfig('/tmp/config.yaml');
         expect(config.agents[0].heartbeatInterval).toBe(1800000);
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });
@@ -853,7 +849,7 @@ agents:
       try {
         const config = loadConfig('/tmp/config.yaml');
         expect(config.agents.length).toBe(3);
-      } catch (err) {
+      } catch {
         // Parsing might fail
       }
     });

src/core/config.test.ts

@@ -81,7 +81,7 @@ vi.mock('../automation/prProcessor.js', () => {
     stop = vi.fn();
   }
   return {
-    PRProcessor: vi.fn((...args) => new MockPRProcessor()),
+    PRProcessor: vi.fn((..._args) => new MockPRProcessor()),
   };
 });
 
@@ -137,7 +137,7 @@ vi.mock('../memory/compaction.js', () => ({
 }));
 
 vi.mock('croner', () => ({
-  Cron: vi.fn((pattern, fn) => ({
+  Cron: vi.fn((_pattern, _fn) => ({
     stop: vi.fn(),
   })),
 }));
@@ -202,12 +202,12 @@ describe('service', () => {
 
     vi.mocked(readProviderOverride).mockReturnValue('gpt');
 
+    // The override reapply lives inside the autonomous-start block (it calls
+    // runnerInstance.switchProvider), so the config must enable autonomous mode.
+    // (INT-2271)
     const config = {
-      ...mockConfig,
+      ...mockAutonomousConfig,
       adapter: 'claude',
-      autonomous: {
-        ...mockConfig.autonomous,
-      },
     } as SwarmConfig;
 
     await startService(config);
@@ -247,7 +247,9 @@ describe('service', () => {
       await startService(mockConfig);
 
       expect(setDefaultAdapter).toHaveBeenCalledWith('claude');
-      expect(readProviderOverride).toHaveBeenCalled();
+      // readProviderOverride is only consulted in the autonomous-start block (it
+      // feeds runnerInstance.switchProvider); a non-autonomous boot doesn't call
+      // it. Its reapply is covered by the two override-specific tests. (INT-2271)
       expect(initLocale).toHaveBeenCalled();
       expect(initLinear).toHaveBeenCalledWith(
         mockConfig.linearApiKey,

src/core/service.test.ts

@@ -298,7 +298,7 @@ describe('TraceCollector', () => {
 
     it('should handle span metadata with complex structures', () => {
       const traceId = collector.startTrace('session');
-      const spanId = collector.startSpan(traceId, 'worker', undefined, {
+      collector.startSpan(traceId, 'worker', undefined, {
         nested: {
           object: {
             with: {
@@ -324,7 +324,7 @@ describe('TraceCollector', () => {
     it('should handle very large metadata values', () => {
       const traceId = collector.startTrace('session');
       const largeString = 'A'.repeat(100000);
-      const spanId = collector.startSpan(traceId, 'worker', undefined, {
+      collector.startSpan(traceId, 'worker', undefined, {
         largeData: largeString,
       });
 
@@ -336,7 +336,7 @@ describe('TraceCollector', () => {
     it('should handle special characters in span names and traces', () => {
       const specialName = 'session-with-special_chars';
       const traceId = collector.startTrace(specialName);
-      const spanId = collector.startSpan(traceId, 'tool:git:special_chars');
+      collector.startSpan(traceId, 'tool:git:special_chars');
 
       const trace = collector.getTrace(traceId);
       expect(trace!.name).toBe(specialName);
@@ -417,7 +417,7 @@ describe('TraceCollector', () => {
 
     it('should handle getChildSpans with non-existent parent', () => {
       const traceId = collector.startTrace('session');
-      const spanId = collector.startSpan(traceId, 'worker')!;
+      collector.startSpan(traceId, 'worker')!;
 
       const children = collector.getChildSpans(traceId, 'non-existent-parent');
       expect(children).toEqual([]);
@@ -445,7 +445,7 @@ describe('TraceCollector', () => {
       const completed1 = collector.startTrace('completed1');
       const completed2 = collector.startTrace('completed2');
       const failed1 = collector.startTrace('failed1');
-      const running1 = collector.startTrace('running1');
+      collector.startTrace('running1');
       const failed2 = collector.startTrace('failed2');
 
       collector.endTrace(completed1, 'completed');
@@ -503,7 +503,7 @@ describe('TraceCollector', () => {
 
     it('should handle empty span name', () => {
       const traceId = collector.startTrace('session');
-      const spanId = collector.startSpan(traceId, '');
+      collector.startSpan(traceId, '');
 
       const trace = collector.getTrace(traceId);
       expect(trace!.spans[0].name).toBe('');

src/core/traceCollector.test.ts

@@ -13,7 +13,6 @@ import {
   EmbedBuilder,
   ThreadChannel,
 } from 'discord.js';
-import { spawn } from 'node:child_process';
 import fs from 'node:fs/promises';
 import type { SwarmEvent, AgentStatus } from '../core/types.js';
 import { getAdapter, spawnCli } from '../adapters/index.js';

src/discord/discordCore.ts

@@ -162,7 +162,6 @@ export async function syncStatusToLinear(
 // ============ 매핑 유틸 ============
 
 function findByLinearId(store: SqliteIssueStore, linearId: string): Issue | null {
-  const { issues } = store.listIssues({ limit: 1, offset: 0 });
   // linear ID로 검색하려면 직접 쿼리가 필요
   // 간단히 전체 목록에서 찾기 (비효율적이지만 동기화는 드물게 실행)
   const { issues: all } = store.listIssues({ limit: 1000, offset: 0 });