fix(git-tracker): a snapshot/diff git failure is infra, not silent '0 changes' (INT-2521)#266
Merged
Merged
Conversation
… changes' (INT-2521)
getChangedFilesSinceSnapshot swallowed a git failure into [] — indistinguishable
from 'no changes' — so the worker's 'did real work' check dropped its actual edits
(uncredited → false STUCK) or masked them. It now throws a 'git-tracker:'-marked
error that isInfraError classifies → infra_error (backoff retry), preserving the
work for the next attempt. takeSnapshot stays best-effort (the reviewer still judges
the real diff) but WARNs loudly so the disabled guard is visible, not silent.
Found by the INT-2521 harness audit (finding F3). Tests: getChangedFilesSince-
Snapshot throws (git-tracker marker) on a bad snapshot tree; isInfraError matches
'git-tracker:'. tsc clean + full vitest 1716.
openswarm review: APPROVE. Applied both suggestions — colon-anchored the marker
('git-tracker:') to avoid prose false-positives, and settle the runGitCommand
timeout before rejecting so late handlers don't double-settle.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getChangedFilesSinceSnapshotswallowed a git failure into[]— indistinguishable from 'no changes' — so the worker's 'did real work' check dropped its actual edits (uncredited → false STUCK) or masked them. It now throws agit-tracker:-marked error thatisInfraErrorclassifies →infra_error(backoff retry), preserving the work.takeSnapshotstays best-effort (the reviewer still judges the real diff) but WARNs loudly so the disabled guard is visible.Found by the INT-2521 audit (F3). Tests: throw on bad snapshot tree;
isInfraErrormatchesgit-tracker:. tsc clean + full vitest 1716.openswarm reviewAPPROVE (applied both suggestions: colon-anchored marker + settle-before-reject on timeout).🤖 Generated with Claude Code