Skip to content

fix: escape pipes in glob paths #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NgoQuocViet2001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escape pipes in glob paths #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ export function isExclude(name: string, exclude?: FilterPattern): boolean {
return false
}

const ESCAPE_PARENTHESES_REGEX = /[()]/g
const ESCAPE_SPECIAL_CHARS_REGEX = /[()|]/g

export function escapeSpecialChars(str: string): string {
return str.replace(ESCAPE_PARENTHESES_REGEX, '\\$&')
return str.replace(ESCAPE_SPECIAL_CHARS_REGEX, '\\$&')
}
8 changes: 7 additions & 1 deletion test/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { ResolvedOptions } from '../src'
import { describe, expect, it } from 'vitest'
import { escapeSpecialChars, getNameFromFilePath } from '../src/core/utils'
import { escapeSpecialChars, getNameFromFilePath, matchGlobs } from '../src/core/utils'

describe('getNameFromFilePath', () => {
const options: Partial<ResolvedOptions> = {
Expand All @@ -25,4 +25,10 @@ describe('escapeSpecialChars', () => {
it('should escape parentheses', () => {
expect(escapeSpecialChars('component()')).toBe('component\\(\\)')
})

it('should escape pipes in glob paths', () => {
const glob = escapeSpecialChars('/work/|presentation/components/**/*.vue')

expect(matchGlobs('/work/|presentation/components/Foo.vue', [glob])).toBe(true)
})
})