Skip to content

Commit 3b05917

Browse files
authored
fix: use node ABI versioning for prebuilt binaries (#44)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the build process to support multiple Node.js environments for enhanced deployment compatibility. - Refined the binary packaging approach to improve overall consistency and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent bf7d7c8 commit 3b05917

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
runs-on: ${{ matrix.os }}
9191
strategy:
9292
matrix:
93-
node-version: [22]
93+
node-version: [18, 22] # 18 is required for cloudflare workers
9494
arch: [amd64, arm64]
9595
os: [ubuntu-latest, macos-latest]
9696
fail-fast: false
@@ -152,8 +152,11 @@ jobs:
152152
*) ARCH_NAME="${{ matrix.arch }}" ;;
153153
esac
154154
155+
# Get Node.js ABI version
156+
NODE_ABI=$(node -e "console.log(process.versions.modules)")
157+
155158
# Construct filename
156-
FILENAME="libvirt-${{ needs.release-please.outputs.tag_name }}-node-${{ matrix.node-version }}-${PLATFORM}-${ARCH_NAME}.tar.gz"
159+
FILENAME="libvirt-${{ needs.release-please.outputs.tag_name }}-node-v${NODE_ABI}-${PLATFORM}-${ARCH_NAME}.tar.gz"
157160
158161
echo "FILENAME=$FILENAME" >> $GITHUB_OUTPUT
159162

0 commit comments

Comments
 (0)