Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

Fix button size on 7.2#52

Merged
dkaser merged 1 commit into
mainfrom
Squidly271-patch-1
Jul 26, 2025
Merged

Fix button size on 7.2#52
dkaser merged 1 commit into
mainfrom
Squidly271-patch-1

Conversation

@Squidly271
Copy link
Copy Markdown
Collaborator

@Squidly271 Squidly271 commented Jul 22, 2025

Summary by CodeRabbit

  • Style
    • Improved the appearance of the settings form by applying a consistent "narrow" style to various dropdowns and input fields.
    • Enhanced the layout of action buttons by wrapping them in styled containers for a more polished look.

Signed-off-by: Squidly271 <unraidsquid@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 22, 2025

Walkthrough

The update modifies the HTML structure and styling of the Tailscale settings form by adding the narrow CSS class to various <select> and <input> elements and wrapping several submit/button inputs within <span> tags. No changes were made to logic, event handling, or control flow.

Changes

File(s) Change Summary
src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php Added narrow CSS class to multiple form elements; wrapped several input buttons in <span> tags for styling.

Estimated code review effort

1 (~2 minutes)


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 144419b and 9595892.

📒 Files selected for processing (1)
  • src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php (13 hunks)
🔇 Additional comments (3)
src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php (3)

65-90: Consistent usage of the narrow class looks good

Adding a common class to all toggle <select> elements keeps the UI consistent and makes them easier to style from a single CSS rule. No functional issues noticed here.

Also applies to: 122-139, 150-154


98-101: Double-check path field usability after shrinking width

class="narrow" may trim the visible width of the Taildrop directory field. If users need to paste / edit long paths (e.g., /mnt/user/backups/photo-archive/2025/07/), the reduced field width can become cumbersome.

Consider either:

-<input … class="narrow"
+<input … class="narrow taildrop-wide"

and then overriding the rule for .taildrop-wide only, or keep the original wider width for this particular input.

Please open the page and confirm the field remains comfortably usable.


167-181: Span-wrapping the action buttons is fine

Grouping related buttons inside a <span> is harmless from a semantics standpoint and often simplifies flex / inline-block layouts. Just make sure any CSS that previously targeted the direct <input> selector is updated (e.g., dd > input[type=submit]) to avoid regressions.

Also applies to: 192-194, 205-206, 216-218


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dkaser dkaser merged commit be29051 into main Jul 26, 2025
3 of 4 checks passed
@dkaser dkaser deleted the Squidly271-patch-1 branch July 26, 2025 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants