fix(plugin-manager): rank validation-failure status by flag, not translated text

The rank logic matched the status cell against the hardcoded English
"update validation failed", but the label is translated via _(). In non-English
locales the match failed and the row sorted to the bottom (rank 4) instead of
the top with updates (rank 0). Track the state with a locale-independent
$validation_failed flag and rank on that instead.

Author: elibosley

emhttp/plugins/dynamix.plugin.manager/include/ShowPlugins.php

@@ -190,6 +190,7 @@
     // silent "up-to-date" the revert would otherwise produce (marker written by
     // the pre_plugin_checks hook). Common cause: the root filesystem is full so
     // the update files can't be downloaded for the integrity check.
+    $validation_failed = false;
     if (!$os && $checked) {
       $invalid = "/tmp/plugins/".basename($plugin_file).".invalid";
       if (is_file($invalid)) {
@@ -201,14 +202,15 @@
           $version .= "<br><span class='red-text'>$newver</span>";
           $status  = "<span class='warning'".($message ? " title='".htmlspecialchars($message,ENT_QUOTES)."'" : "")."><i class='fa fa-exclamation-triangle' aria-hidden='true'></i> "._('update validation failed')."</span>";
           if ($summary !== '') $status .= "<br><span class='orange-text' style='font-size:smaller'>".htmlspecialchars($summary,ENT_QUOTES)."</span>";
+          $validation_failed = true;
         } else {
           @unlink($invalid);
         }
       }
     }
-    if (strpos($status,'update')!==false) $rank = '0';
+    if ($validation_failed) $rank = '0';
+    elseif (strpos($status,'update')!==false) $rank = '0';
     elseif (strpos($status,'install')!==false) $rank = '1';
-    elseif (strpos($status,'update validation failed')!==false) $rank = '0';
     elseif ($status=='need check') $rank = '2';
     elseif ($status=='up-to-date') $rank = '3';
     else $rank = '4';