Skip to content

feat: offline copy changes#2627

Merged
limetech merged 6 commits into
masterfrom
feat/offline-copy-fix
May 5, 2026
Merged

feat: offline copy changes#2627
limetech merged 6 commits into
masterfrom
feat/offline-copy-fix

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented Apr 28, 2026

Summary by CodeRabbit

  • Style
    • Standardized user interface text across array operations, filesystem states, and device status displays: replaced "off-line" with "offline" and "on-line" with "online" for consistent spelling convention.

- Purpose: normalize user-facing status copy from "off-line" to "offline" across the web UI.
- Before: the array stop helper text, offline usage-bar state, and device status label used the hyphenated spelling "off-line".
- Problem: the wording was inconsistent with the rest of the UI and read like a typo in the affected screens.
- Change: replace those strings with "offline" in the three affected views/helpers.
- How: update the static copy in ArrayOperation, the offline usage-bar fallback in Helpers, and the stopped-array status text in nchan/update_2.
- Purpose: normalize remaining array state helper copy from "on-line" to "online".
- Before: ArrayOperation start-state helper text used the hyphenated form "on-line" across multiple stopped-array paths.
- Problem: the wording was inconsistent with the rest of the UI and did not match the earlier offline normalization.
- Change: replace all user-facing "on-line" strings in ArrayOperation with "online".
- How: update the start-action helper text for configuration-valid, parity-check, disk-clear, rebuild, and related array start states.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9aa530f7-29ba-45ac-83bb-b728fb630410

📥 Commits

Reviewing files that changed from the base of the PR and between ef1f4d6 and b3f1089.

📒 Files selected for processing (3)
  • emhttp/plugins/dynamix/ArrayOperation.page
  • emhttp/plugins/dynamix/include/Helpers.php
  • emhttp/plugins/dynamix/nchan/update_2

Walkthrough

Three files updated with consistent spelling conventions for offline/online terminology in UI display strings. Replaced hyphenated forms ("off-line," "on-line") with unhyphenated versions ("offline," "online") across array operation messages, filesystem state labels, and device status rendering. No functional or control flow changes.

Changes

Cohort / File(s) Summary
UI Text Standardization
emhttp/plugins/dynamix/ArrayOperation.page, emhttp/plugins/dynamix/include/Helpers.php, emhttp/plugins/dynamix/nchan/update_2
Unified spelling convention by replacing "off-line" with "offline" and "on-line" with "online" across array operation messages, filesystem state labels, and device status rendering. All changes are cosmetic text updates with no functional impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Offline and online, now spelled neat,
Hyphens removed, the terminology's sweet,
No logic breaks, just spelling refined,
Consistency gleams across every line—
A rabbit's delight: order redefined! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'feat: offline copy changes' is vague and does not clearly convey the actual changes, which are standardizing spelling/convention from 'off-line'/'on-line' to 'offline'/'online' across UI text. Revise the title to be more specific, such as 'Standardize offline/online spelling in UI text' or 'Use consistent offline/online terminology across UI messages'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/offline-copy-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.28.2014
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2627/webgui-pr-2627.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/ArrayOperation.page
emhttp/plugins/dynamix/include/Helpers.php
emhttp/plugins/dynamix/nchan/update_2

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2627, or run:

plugin remove webgui-pr-2627

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@limetech limetech merged commit c72475e into master May 5, 2026
9 checks passed
@limetech limetech deleted the feat/offline-copy-fix branch May 5, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants