Skip to content

fix(help): correct FTP server default text#2633

Merged
limetech merged 1 commit into
masterfrom
codex/update-ftp-help-default
May 11, 2026
Merged

fix(help): correct FTP server default text#2633
limetech merged 1 commit into
masterfrom
codex/update-ftp-help-default

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented May 11, 2026

Summary

  • Update FTP server help text to say the FTP server is disabled by default.
  • Keep the change scoped to the English help text entry for :ftp_server_help:.

Validation

  • rg -n "By default the FTP server is disabled" emhttp/languages/en_US/helptext.txt
  • Checked root@unraid.local read-only: /etc/inetd.conf has the FTP vsftpd line commented and port 21 has no listener.

Summary by CodeRabbit

  • Documentation
    • Updated FTP server help text to clarify that the FTP server daemon is disabled by default and can be toggled on or off via settings.

Review Change Stack

Purpose of the change:
- Update the FTP settings help text to describe the current default server state.

Previous behavior:
- The help text said the FTP server is enabled by default.

Why that was a problem:
- The default inetd FTP entry is commented out, so the help text contradicted the default disabled state.

New behavior:
- The FTP help text now says the FTP server is disabled by default.

How it works:
- Changes only the localized English help text for :ftp_server_help:.
@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.05.11.1731
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2633/webgui-pr-2633.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/languages/en_US/helptext.txt

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2633, or run:

plugin remove webgui-pr-2633

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1e2816ae-4162-4965-b9ee-65c9a89ca7ff

📥 Commits

Reviewing files that changed from the base of the PR and between c72475e and 6ccc6d9.

📒 Files selected for processing (1)
  • emhttp/languages/en_US/helptext.txt

Walkthrough

A single-line localization update modifies the FTP server help text to state that the daemon is disabled by default and clarifies that the setting controls enable/disable functionality.

Help Text Update

Layer / File(s) Summary
FTP Server Help Text
emhttp/languages/en_US/helptext.txt
:ftp_server_help: text is updated to indicate the FTP server daemon is disabled by default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A fuzzy rabbit hops with glee,
For FTP now disabled to see,
One line changed, so clear and bright,
Default set just right,
The user's help text flows so free! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely describes the main change: correcting the FTP server default text in help documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/update-ftp-help-default

Comment @coderabbitai help to get the list of available commands and usage tips.

@elibosley elibosley marked this pull request as ready for review May 11, 2026 17:35
@elibosley elibosley added the 7.3 label May 11, 2026
@limetech limetech merged commit aba2552 into master May 11, 2026
5 checks passed
@limetech limetech deleted the codex/update-ftp-help-default branch May 11, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants