fix: restore the orphan image row's Created date to the Uptime column#2695
fix: restore the orphan image row's Created date to the Uptime column#2695chodeus wants to merge 1 commit into
Conversation
The orphan image row emits 1 + colspan=6 + 1 = 8 cells against a 10-column thead, so "Created" lands under "CPU & Memory load" and the Autostart and Uptime columns get no cell at all. colspan='6' was correct when the thead had 8 columns. Splitting Port Mappings into Container IP / Container Port / LAN IP:Port took it to 10 without bumping the colspan. Widening to 8 restores the row to a full 10 slots, matching the pre-split shape where the colspan also covered through Autostart.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe orphan image row’s image ID cell now spans eight columns instead of six, aligning the row with the Docker table’s ten-column layout. ChangesDocker orphan image row
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Fixes #2694 — the orphan image row emits
1 + colspan='6' + 1 = 8cells against a 10-column thead, so "Created ..." renders under CPU & Memory load instead of Uptime, and the Autostart/Uptime slots get no cell at all (which is why the row background stops at the Autostart boundary).colspan='6'was correct until the thead grew.b5f2e9da9(2023-03-25, "Fix table layout for orphan images") set it to 6 when the thead had 8 columns —1+6+1 = 8fit exactly and "Created" landed in Uptime.8cabad6f0(2024-08-08) split Port Mappings into Container IP / Container Port / LAN IP:Port, taking the thead to 10 without bumping the colspan.Changes
include/DockerContainers.php(orphan image loop) — widen the Image ID cell fromcolspan='6'tocolspan='8', so the row spans a full1 + 8 + 1 = 10slots. "Created" returns to column 10 (Uptime) and the row background spans the table. This matches the pre-split shape, where the colspan also covered through Autostart — orphan images have no autostart control, so nothing is displaced.Testing (real hardware, per the README workflow)
Tested on Unraid 7.3.2 with two orphan images present, Docker tab in Advanced view.
The orphan image block (L303-311) is byte-identical between 7.3.2 and master at
369f0b2, so the patched master file was copied to the live server directly. (The server's only other delta in this file is L100, from my in-flight #2693, which is unrelated to the orphan row.)php -lclean.Measured the orphan row against the live thead, before → after:
colspan='6')colspan='8')1221→13951495→16921221→13951221→13951495→16921495→1692Before, the Created cell's x-range matched the CPU & Memory load header exactly; after, it matches the Uptime header exactly. (Absolute x-values are specific to this box's column widths — the load-bearing result is the exact alignment change and the 8 → 10 span. My test box runs my own folder plugin, which pins column widths on this table but does not touch orphan rows or cell/column assignment; the before/after pair above was measured on one page with identical widths, isolating the colspan as the only variable.)
Row background now spans the full table width instead of terminating at the Autostart boundary.
Both orphan rows on the box render correctly; container rows are unaffected (they already emit all 10 cells and this change does not touch them).
Basic view unchanged — orphan rows are
tr.advancedand remain hidden there.Summary by CodeRabbit