Merge pull request #77 from uptick/fix/strict-parsing-for-month-text-input

cat-bro · web-flow · commit 3744a46f915d · 2019-03-06T15:30:35.000+11:00
UP-1700 Use strict parsing in Month.js handleTextChange
diff --git a/src/filters/types/Month.js b/src/filters/types/Month.js
@@ -48,7 +48,8 @@ class Month extends React.Component {
     const textValue = this.refs.textInput.value
     let monthValue
     this.setState(() => ({textValue: textValue}))
-    const parsedMonth = moment(textValue, this.props.format)
+    // use the moment option strict=true to prevent excessive preemptive parsing
+    const parsedMonth = moment(textValue, this.props.format, true)
     if (parsedMonth.isValid()) {
       monthValue = parsedMonth
     } else {
diff --git a/src/filters/types/__tests__/Month.test.js b/src/filters/types/__tests__/Month.test.js
@@ -56,7 +56,7 @@ describe('Month', () => {
             value: 'Jan 2016',
           },
         }
-        const monthValue = Moment(instance.refs.textInput.value, instance.props.format)
+        const monthValue = Moment(instance.refs.textInput.value, instance.props.format, true) // strict=true
         instance.handleTextChange()
         expect(instance.state.textValue).toBe(instance.refs.textInput.value)
         expect(baseProps.onChange).toHaveBeenCalledWith(monthValue)

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ describe('Month', () => {`
`56`	`56`	`value: 'Jan 2016',`
`57`	`57`	`},`
`58`	`58`	`}`
`59`		`- const monthValue = Moment(instance.refs.textInput.value, instance.props.format)`
	`59`	`+ const monthValue = Moment(instance.refs.textInput.value, instance.props.format, true) // strict=true`
`60`	`60`	`instance.handleTextChange()`
`61`	`61`	`expect(instance.state.textValue).toBe(instance.refs.textInput.value)`
`62`	`62`	`expect(baseProps.onChange).toHaveBeenCalledWith(monthValue)`