Merge pull request #2317 from barry3406/fix/completion-shebang

fix: drop shebang from bash completion template

Author: dearchap

autocomplete/bash_autocomplete

@@ -1,5 +1,3 @@
-#!/bin/bash
-
 # This is a shell completion script auto-generated by https://github.com/urfave/cli for bash.
 
 # macOS still ships Bash 3, where bash-completion may not provide

completion_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -63,6 +64,27 @@ func TestCompletionShell(t *testing.T) {
 	}
 }
 
+func TestCompletionBashNoShebang(t *testing.T) {
+	// Regression test for https://github.com/urfave/cli/issues/2259
+	// Bash completion scripts are sourced, not executed, so they must not
+	// start with a `#!` shebang (flagged by Debian lintian as
+	// `bash-completion-with-hashbang`).
+
+	cmd := &Command{
+		EnableShellCompletion: true,
+	}
+
+	r := require.New(t)
+
+	bashRender := shellCompletions["bash"]
+	r.NotNil(bashRender, "bash completion renderer should exist")
+
+	output, err := bashRender(cmd, "myapp")
+	r.NoError(err)
+	r.NotEmpty(output, "bash completion output should not be empty")
+	r.False(strings.HasPrefix(output, "#!"), "bash completion should not start with a shebang")
+}
+
 func TestCompletionFishFormat(t *testing.T) {
 	// Regression test for https://github.com/urfave/cli/issues/2285
 	// Fish completion was broken due to incorrect format specifiers