fix: drop shebang from bash completion template#2317
Merged
dearchap merged 1 commit intourfave:mainfrom Apr 18, 2026
Merged
Conversation
Bash completion scripts are sourced, not executed, so they should not begin with a `#!/bin/bash` shebang. Debian's lintian flags this as `bash-completion-with-hashbang`. Add a regression test that renders the bash completion and asserts the output does not start with `#!`. Fixes urfave#2259
dearchap
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Bash completion scripts are sourced (not executed), so they shouldn't start with a
#!/bin/bashshebang. Debian's lintian flags the generated completion withbash-completion-with-hashbangwhen downstream packagers ship it.autocomplete/bash_autocomplete: drops the shebang line (and the blank line that followed it) so the embedded template starts with the existing# This is a shell completion script ...header comment.completion_test.go: addsTestCompletionBashNoShebang, which renders the bash completion viashellCompletions["bash"]and asserts the output does not start with#!.Which issue(s) this PR fixes:
Fixes #2259
Testing
go test ./...andgo vet ./...pass locally. The new test fails without the template change and passes with it.Release Notes