Skip to content

Change content-type header to use application/x-ndjson#58

Open
chemass wants to merge 1 commit into
urielha:masterfrom
chemass:master
Open

Change content-type header to use application/x-ndjson#58
chemass wants to merge 1 commit into
urielha:masterfrom
chemass:master

Conversation

@chemass
Copy link
Copy Markdown

@chemass chemass commented Mar 13, 2020

because application/json does not work.

@eran-gil
Copy link
Copy Markdown
Collaborator

I think it's better you move it to a configuration parameter where the default value is the current one.
Then everyone will be able to make their choice for the content type.

@eran-gil eran-gil requested review from eran-gil and urielha March 18, 2020 13:30
Copy link
Copy Markdown
Collaborator

@eran-gil eran-gil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to configuration with the default value of the new parameter being the current state.

@eran-gil eran-gil force-pushed the master branch 2 times, most recently from afffd78 to 07c0b49 Compare April 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants