Commit b85747b
fix: use fixed-size Eigen vectors for plane-fit members
normal_, singular_values_, and pc_mean_ were declared as Eigen::VectorXf
(dynamic-size). When a partial (non-360°) point cloud is processed
— e.g. an OS1 128 Ouster pointcloud that doesn't start at azimuth 0 —
the dynamic vectors are accessed at fixed indices before being sized,
producing an immediate crash at startup.
Switch all three to Eigen::Vector3f. Matches the SVD output (Vector3f
from JacobiSVD<MatrixX3f>) and the existing per-index accesses
(e.g. singular_values_.minCoeff(), pc_mean_(0..2), normal_(0..2)).
Co-authored-by: MatteGombia <matteogombia@gmail.com>
Closes #621 parent eeeb6aa commit b85747b
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
192 | | - | |
| 191 | + | |
| 192 | + | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
0 commit comments