Remove sudo from various commaci: remove all sudo calls as container runs as root and sudo is missingnds in vm_test.yml

Author: imshubham22apr-gif

.github/workflows/vm_test.yml

@@ -101,7 +101,7 @@ jobs:
       - name: Pre-checkout dependencies
         run: |
           if command -v zypper >/dev/null; then
-            sudo zypper install -y tar gzip
+            zypper install -y tar gzip
           fi
 
       - uses: actions/checkout@v4
@@ -119,91 +119,91 @@ jobs:
       - name: Install base dependencies
         run: |
           if command -v apt-get >/dev/null; then
-            sudo apt-get update
-            sudo apt-get install -y git wget curl build-essential libseccomp-dev pkg-config bc make qemu-system sudo e2fsprogs ca-certificates tar
+            apt-get update
+            apt-get install -y git wget curl build-essential libseccomp-dev pkg-config bc make qemu-system e2fsprogs ca-certificates tar
           elif command -v dnf >/dev/null; then
-            sudo dnf install -y --allowerasing git wget curl gcc gcc-c++ make libseccomp-devel pkgconfig bc sudo e2fsprogs ca-certificates tar
+            dnf install -y --allowerasing git wget curl gcc gcc-c++ make libseccomp-devel pkgconfig bc e2fsprogs ca-certificates tar
           elif command -v zypper >/dev/null; then
-            sudo zypper install -y git wget curl gcc gcc-c++ make libseccomp-devel pkg-config bc qemu-x86 sudo e2fsprogs ca-certificates tar
+            zypper install -y git wget curl gcc gcc-c++ make libseccomp-devel pkg-config bc qemu-x86 e2fsprogs ca-certificates tar
           else
             echo "Unsupported distribution"
             exit 1
           fi
           wget https://s3.nbfc.io/nbfc-assets/github/urunc/bin/virtiofsd
-          sudo chmod +x virtiofsd
-          sudo mv virtiofsd /usr/libexec/virtiofsd
+          chmod +x virtiofsd
+          mv virtiofsd /usr/libexec/virtiofsd
 
       - name: Install runc
         run: |
           wget https://github.com/opencontainers/runc/releases/download/${{ inputs.runc_version }}/runc.${{ matrix.arch }}
-          sudo install -m 755 runc.${{ matrix.arch }} /usr/local/sbin/runc
+          install -m 755 runc.${{ matrix.arch }} /usr/local/sbin/runc
 
       - name: Install containerd
         run: |
           wget https://github.com/containerd/containerd/releases/download/v${{ inputs.containerd_version }}/containerd-${{ inputs.containerd_version }}-linux-${{ matrix.arch }}.tar.gz
-          sudo tar Cxzvf /usr/local containerd-${{ inputs.containerd_version }}-linux-${{ matrix.arch }}.tar.gz
+          tar Cxzvf /usr/local containerd-${{ inputs.containerd_version }}-linux-${{ matrix.arch }}.tar.gz
 
       - name: Set up containerd service
         run: |
-          sudo mkdir -p /usr/local/lib/systemd/system
-          sudo wget https://raw.githubusercontent.com/containerd/containerd/main/containerd.service -O /usr/local/lib/systemd/system/containerd.service
-          sudo systemctl daemon-reload
-          sudo systemctl enable --now containerd
+          mkdir -p /usr/local/lib/systemd/system
+          wget https://raw.githubusercontent.com/containerd/containerd/main/containerd.service -O /usr/local/lib/systemd/system/containerd.service
+          systemctl daemon-reload
+          systemctl enable --now containerd
 
       - name: Configure containerd
         run: |
-          sudo mkdir -p /etc/containerd
-          containerd config default | sudo tee /etc/containerd/config.toml
+          mkdir -p /etc/containerd
+          containerd config default | tee /etc/containerd/config.toml
 
       - name: Restart containerd
         run: |
-          sudo systemctl restart containerd
+          systemctl restart containerd
 
       - name: Setup devmapper
         run: |
-          sudo modprobe dm_thin_pool
-          sudo mkdir -p /var/lib/containerd/devmapper
+          modprobe dm_thin_pool
+          mkdir -p /var/lib/containerd/devmapper
           # Use a loop device for devmapper in CI
-          sudo dd if=/dev/zero of=/var/lib/containerd/devmapper/data bs=1M count=1024
-          sudo dd if=/dev/zero of=/var/lib/containerd/devmapper/metadata bs=1M count=128
-          DATA_DEV=$(sudo losetup -f --show /var/lib/containerd/devmapper/data)
-          META_DEV=$(sudo losetup -f --show /var/lib/containerd/devmapper/metadata)
-          sudo dmsetup create containerd-pool --table "0 2097152 thin-pool $META_DEV $DATA_DEV 128 32768"
+          dd if=/dev/zero of=/var/lib/containerd/devmapper/data bs=1M count=1024
+          dd if=/dev/zero of=/var/lib/containerd/devmapper/metadata bs=1M count=128
+          DATA_DEV=$(losetup -f --show /var/lib/containerd/devmapper/data)
+          META_DEV=$(losetup -f --show /var/lib/containerd/devmapper/metadata)
+          dmsetup create containerd-pool --table "0 2097152 thin-pool $META_DEV $DATA_DEV 128 32768"
 
       - name: Setup block-based mountpoint
         run: |
-          sudo mkdir -p /mnt/urunc-test
-          sudo dd if=/dev/zero of=/tmp/urunc-test.img bs=1M count=512
-          sudo mkfs.ext4 /tmp/urunc-test.img
-          sudo mount /tmp/urunc-test.img /mnt/urunc-test
+          mkdir -p /mnt/urunc-test
+          dd if=/dev/zero of=/tmp/urunc-test.img bs=1M count=512
+          mkfs.ext4 /tmp/urunc-test.img
+          mount /tmp/urunc-test.img /mnt/urunc-test
 
       - name: Install CNI plugins
         run: |
-          sudo mkdir -p /opt/cni/bin
+          mkdir -p /opt/cni/bin
           wget https://github.com/containernetworking/plugins/releases/download/v${{ inputs.cni_version }}/cni-plugins-linux-${{ matrix.arch }}-v${{ inputs.cni_version }}.tgz
-          sudo tar Cxzvf /opt/cni/bin cni-plugins-linux-${{ matrix.arch }}-v${{ inputs.cni_version }}.tgz
+          tar Cxzvf /opt/cni/bin cni-plugins-linux-${{ matrix.arch }}-v${{ inputs.cni_version }}.tgz
 
       - name: Install nerdctl
         run: |
           wget https://github.com/containerd/nerdctl/releases/download/v1.7.5/nerdctl-1.7.5-linux-${{ matrix.arch }}.tar.gz
-          sudo tar Cxzvf /usr/local/bin nerdctl-1.7.5-linux-${{ matrix.arch }}.tar.gz
+          tar Cxzvf /usr/local/bin nerdctl-1.7.5-linux-${{ matrix.arch }}.tar.gz
 
       - name: Install crictl
         run: |
           wget https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.29.0/crictl-v1.29.0-linux-${{ matrix.arch }}.tar.gz
-          sudo tar Cxzvf /usr/local/bin crictl-v1.29.0-linux-${{ matrix.arch }}.tar.gz
+          tar Cxzvf /usr/local/bin crictl-v1.29.0-linux-${{ matrix.arch }}.tar.gz
 
       - name: Install Firecracker
         run: |
           FC_URL="https://github.com/firecracker-microvm/firecracker/releases/download/v1.7.0/firecracker-v1.7.0-$(uname -m)"
           wget $FC_URL -O firecracker
-          sudo install -m 755 firecracker /usr/local/bin/firecracker
+          install -m 755 firecracker /usr/local/bin/firecracker
 
       - name: Install Cloud Hypervisor
         run: |
           CH_URL="https://github.com/cloud-hypervisor/cloud-hypervisor/releases/download/v39.0/cloud-hypervisor"
           wget $CH_URL
-          sudo install -m 755 cloud-hypervisor /usr/local/bin/cloud-hypervisor
+          install -m 755 cloud-hypervisor /usr/local/bin/cloud-hypervisor
 
       - name: Install solo5
         run: |
@@ -213,7 +213,7 @@ jobs:
           cd solo5-v${{ inputs.solo5_version }}
           ./configure.sh
           make
-          sudo make install
+          make install
 
       - name: Download urunc artifact
         uses: actions/download-artifact@v4 # v4.1.8
@@ -227,34 +227,34 @@ jobs:
 
       - name: Install urunc
         run: |
-          sudo install -m 755 urunc /usr/local/sbin/urunc
-          sudo install -m 755 containerd-shim-urunc-v2 /usr/local/sbin/containerd-shim-urunc-v2
+          install -m 755 urunc /usr/local/sbin/urunc
+          install -m 755 containerd-shim-urunc-v2 /usr/local/sbin/containerd-shim-urunc-v2
 
       - name: Configure urunc with debug logging
         run: |
-          sudo mkdir -p /etc/urunc
-          echo '{"log_level": "debug"}' | sudo tee /etc/urunc/config.json
+          mkdir -p /etc/urunc
+          echo '{"log_level": "debug"}' | tee /etc/urunc/config.json
 
       - name: Add runner user to KVM group
         run: |
-          sudo usermod -aG kvm $(whoami)
+          usermod -aG kvm $(whoami)
 
       - name: Prepare urunc folder
         run: |
-          sudo mkdir -p /var/lib/urunc
+          mkdir -p /var/lib/urunc
 
       - name: Run ${{ matrix.test }}
         run: |
           case "${{ matrix.test }}" in
-            test_ctr) sudo ./tests/e2e/test_ctr.sh ;;
-            test_nerdctl) sudo ./tests/e2e/test_nerdctl.sh ;;
-            test_crictl) sudo ./tests/e2e/test_crictl.sh ;;
-            test_docker) sudo ./tests/e2e/test_docker.sh ;;
+            test_ctr) ./tests/e2e/test_ctr.sh ;;
+            test_nerdctl) ./tests/e2e/test_nerdctl.sh ;;
+            test_crictl) ./tests/e2e/test_crictl.sh ;;
+            test_docker) ./tests/e2e/test_docker.sh ;;
           esac
 
       - name: Dump urunc logs on failure
         if: failure()
         run: |
-          sudo journalctl -u containerd --no-pager
-          sudo cat /tmp/containerd.log || true
+          journalctl -u containerd --no-pager
+          cat /tmp/containerd.log || true