Refactor steps in vm_test.yml for coci: fix YAML indentation in prepare job stepsnsistency

imshubham22apr-gif · web-flow · commit af2927e3a2c4 · 2026-05-14T11:06:14.000+05:30
diff --git a/.github/workflows/vm_test.yml b/.github/workflows/vm_test.yml
@@ -78,9 +78,9 @@ jobs:
             container_image: opensuse/leap:latest
 
     steps:
-    - name: Validate inputs (prevent command injection)
-      shell: bash
-      env:
+      - name: Validate inputs (prevent command injection)
+        shell: bash
+        env:
         GO_VERSION: ${{ inputs.go_version }}
         RUNC_VERSION: ${{ inputs.runc_version }}
         CONTAINERD_VERSION: ${{ inputs.containerd_version }}
@@ -90,7 +90,7 @@ jobs:
         FIRECRACKER_VERSION: ${{ inputs.firecracker_version }}
         CLOUD_HYPERVISOR_VERSION: ${{ inputs.cloud_hypervisor_version }}
         SOLO5_VERSION: ${{ inputs.solo5_version }}
-      run: |
+        run: |
         SAFE_GO_VERSION="$GO_VERSION"
         SAFE_RUNC_VERSION="$RUNC_VERSION"
         SAFE_CONTAINERD_VERSION="$CONTAINERD_VERSION"
@@ -108,13 +108,10 @@ jobs:
             exit 1
           fi
         done
-
-
-    - name: Harden the runner (Audit all outbound calls)
-      uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
-      with:
+      - name: Harden the runner (Audit all outbound calls)
+        uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
+        with:
         egress-policy: audit
-
       - name: Pre-checkout dependencies
         run: |
           if command -v zypper >/dev/null; then
@@ -124,12 +121,11 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
     - uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
-      with:
+        with:
         go-version: ${{ inputs.go_version }}
         cache: false
-
-    - name: Install base dependencies
-      run: |
+      - name: Install base dependencies
+        run: |
         # Fallback for missing sudo in minimal containers
         if ! command -v sudo >/dev/null; then
           sudo() { "$@"; }
@@ -150,11 +146,10 @@ jobs:
         wget https://s3.nbfc.io/nbfc-assets/github/urunc/bin/virtiofsd
         sudo chmod +x virtiofsd
         sudo mv virtiofsd /usr/libexec/virtiofsd
-
-    - name: Install runc
-      env:
+      - name: Install runc
+        env:
         RUNC_VERSION: ${{ inputs.runc_version }}
-      run: |
+        run: |
         SAFE_RUNC="${RUNC_VERSION}"
         ARCH=$(uname -m)
         case $ARCH in
@@ -165,11 +160,10 @@ jobs:
         wget -q "https://github.com/opencontainers/runc/releases/download/v${SAFE_RUNC}/runc.${BIN_ARCH}"
         sudo install -m 755 runc.${BIN_ARCH} /usr/local/sbin/runc
         rm -f ./runc.${BIN_ARCH}
-
-    - name: Install containerd
-      env:
+      - name: Install containerd
+        env:
         CONTAINERD_VERSION: ${{ inputs.containerd_version }}
-      run: |
+        run: |
         SAFE_CONTAINERD="${CONTAINERD_VERSION}"
         ARCH=$(uname -m)
         case $ARCH in
@@ -180,11 +174,10 @@ jobs:
         wget -q "https://github.com/containerd/containerd/releases/download/v${SAFE_CONTAINERD}/containerd-${SAFE_CONTAINERD}-linux-${BIN_ARCH}.tar.gz"
         sudo tar Cxzvf /usr/local "containerd-${SAFE_CONTAINERD}-linux-${BIN_ARCH}.tar.gz"
         rm -f "containerd-${SAFE_CONTAINERD}-linux-${BIN_ARCH}.tar.gz"
-
-    - name: Set up containerd service
-      env:
+      - name: Set up containerd service
+        env:
         CONTAINERD_VERSION: ${{ inputs.containerd_version }}
-      run: |
+        run: |
         SAFE_CONTAINERD="$CONTAINERD_VERSION"
         wget -q "https://raw.githubusercontent.com/containerd/containerd/v${SAFE_CONTAINERD}/containerd.service"
         sudo rm -f /lib/systemd/system/containerd.service
@@ -197,25 +190,22 @@ jobs:
           sudo containerd > /tmp/containerd.log 2>&1 &
           sleep 5
         fi
-
-    - name: Configure containerd
-      run: |
+      - name: Configure containerd
+        run: |
         sudo mkdir -p /etc/containerd/
         sudo mv /etc/containerd/config.toml /etc/containerd/config.toml.bak || true
         sudo containerd config default | sudo tee /etc/containerd/config.toml
-
-    - name: Restart containerd
-      run: |
+      - name: Restart containerd
+        run: |
         if command -v systemctl >/dev/null && systemctl is-system-running >/dev/null 2>&1; then
           sudo systemctl restart containerd
         else
           sudo pkill containerd || true
           sudo containerd > /tmp/containerd.log 2>&1 &
           sleep 5
         fi
-
-    - name: Setup devmapper
-      run: |
+      - name: Setup devmapper
+        run: |
         sudo mkdir -p /usr/local/bin/scripts
         sudo cp script/dm_create.sh /usr/local/bin/scripts/dm_create.sh
         sudo chmod 755 /usr/local/bin/scripts/dm_create.sh
@@ -242,18 +232,16 @@ jobs:
           sudo containerd &
           sleep 5
         fi
-
-    - name: Setup block-based mountpoint
-      run: |
+      - name: Setup block-based mountpoint
+        run: |
         mkdir /tmp/test_mountpoint
         dd if=/dev/zero of=/tmp/fake_block bs=1M count=200
         mkfs.ext2 /tmp/fake_block
         sudo mount /tmp/fake_block /tmp/test_mountpoint
-
-    - name: Install CNI plugins
-      env:
+      - name: Install CNI plugins
+        env:
         CNI_VERSION: ${{ inputs.cni_version }}
-      run: |
+        run: |
         SAFE_CNI="${CNI_VERSION}"
         ARCH=$(uname -m)
         case $ARCH in
@@ -265,11 +253,10 @@ jobs:
         sudo mkdir -p /opt/cni/bin
         sudo tar Cxzvf /opt/cni/bin "cni-plugins-linux-${BIN_ARCH}-v${SAFE_CNI}.tgz"
         rm -f "cni-plugins-linux-${BIN_ARCH}-v${SAFE_CNI}.tgz"
-
-    - name: Install nerdctl
-      env:
+      - name: Install nerdctl
+        env:
         NERDCTL_VERSION: ${{ inputs.nerdctl_version }}
-      run: |
+        run: |
         SAFE_NERDCTL="${NERDCTL_VERSION}"
         ARCH=$(uname -m)
         case $ARCH in
@@ -280,11 +267,10 @@ jobs:
         wget -q "https://github.com/containerd/nerdctl/releases/download/v${SAFE_NERDCTL}/nerdctl-${SAFE_NERDCTL}-linux-${BIN_ARCH}.tar.gz"
         sudo tar Cxzvf /usr/local/bin "nerdctl-${SAFE_NERDCTL}-linux-${BIN_ARCH}.tar.gz"
         rm -f "nerdctl-${SAFE_NERDCTL}-linux-${BIN_ARCH}.tar.gz"
-
-    - name: Install crictl
-      env:
+      - name: Install crictl
+        env:
         CRICTL_VERSION: ${{ inputs.crictl_version }}
-      run: |
+        run: |
         SAFE_CRI="${CRICTL_VERSION}"
         wget "https://github.com/kubernetes-sigs/cri-tools/releases/download/${SAFE_CRI}/crictl-${SAFE_CRI}-linux-${{ matrix.arch }}.tar.gz"
         sudo tar zxvf "crictl-${SAFE_CRI}-linux-${{ matrix.arch }}.tar.gz" -C /usr/local/bin
@@ -294,31 +280,28 @@ jobs:
         image-endpoint: unix:///run/containerd/containerd.sock
         timeout: 20
         EOT
-
-    - name: Install Firecracker
-      env:
+      - name: Install Firecracker
+        env:
         FC_VERSION: ${{ inputs.firecracker_version }}
-      run: |
+        run: |
         SAFE_FC="${FC_VERSION}"
         ARCH="$(uname -m)"
         release_url="https://github.com/firecracker-microvm/firecracker/releases"
         curl -L "${release_url}/download/${SAFE_FC}/firecracker-${SAFE_FC}-${ARCH}.tgz" | tar -xz
         sudo mv "release-${SAFE_FC}-${ARCH}/firecracker-${SAFE_FC}-${ARCH}" /usr/local/bin/firecracker
         rm -fr "release-${SAFE_FC}-${ARCH}"
-
-    - name: Install Cloud Hypervisor
-      env:
+      - name: Install Cloud Hypervisor
+        env:
         CLOUD_HYPERVISOR_VERSION: ${{ inputs.cloud_hypervisor_version }}
-      run: |
+        run: |
         SAFE_CLOUD_HYPERVISOR="${CLOUD_HYPERVISOR_VERSION}"
         curl -sL "https://github.com/cloud-hypervisor/cloud-hypervisor/releases/download/${SAFE_CLOUD_HYPERVISOR}/cloud-hypervisor-static" -o cloud-hypervisor
         chmod +x cloud-hypervisor
         sudo mv cloud-hypervisor /usr/local/bin/cloud-hypervisor
-
-    - name: Install solo5
-      env:
+      - name: Install solo5
+        env:
         SOLO5_VERSION: ${{ inputs.solo5_version }}
-      run: |
+        run: |
         SAFE_SOLO5="${SOLO5_VERSION}"
         git clone -b "${SAFE_SOLO5}" https://github.com/Solo5/solo5.git
         cd solo5
@@ -328,41 +311,36 @@ jobs:
         make -j$(nproc)
         sudo cp tenders/hvt/solo5-hvt /usr/local/bin
         sudo cp tenders/spt/solo5-spt /usr/local/bin
-
-    - name: Download urunc artifact
-      uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
-      with:
+      - name: Download urunc artifact
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+        with:
         name: urunc_static_${{ matrix.arch }}-${{ github.run_id }}
         path: ./
-
-    - name: Download containerd-shim-urunc-v2 artifact
-      uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
-      with:
+      - name: Download containerd-shim-urunc-v2 artifact
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+        with:
         name: containerd-shim-urunc-v2_static_${{ matrix.arch }}-${{ github.run_id }}
         path: ./
-
-    - name: Install urunc
+      - name: Install urunc
       id: install-urunc
-      run: |
+        run: |
         chmod +x urunc_static_${{ matrix.arch }}
         chmod +x containerd-shim-urunc-v2_static_${{ matrix.arch }}
         sudo mv urunc_static_${{ matrix.arch }} /usr/local/bin/urunc
         sudo mv containerd-shim-urunc-v2_static_${{ matrix.arch }} /usr/local/bin/containerd-shim-urunc-v2
         urunc --version
-
-    - name: Configure urunc with debug logging
-      run: |
+      - name: Configure urunc with debug logging
+        run: |
         sudo mkdir -p /etc/urunc
         sudo tee /etc/urunc/config.toml > /dev/null <<'EOF'
         [log]
         level = "debug"
         syslog = true
         EOF
-
-    - name: Add runner user to KVM group
+      - name: Add runner user to KVM group
       if: ${{ matrix.arch == 'amd64' }}
       id: kvm-setup
-      run: |
+        run: |
         if [ -c /dev/kvm ]; then
           echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules || true
           if command -v udevadm >/dev/null; then
@@ -375,19 +353,17 @@ jobs:
         else
           echo "/dev/kvm not found, skipping KVM setup"
         fi
-
-    - name: Prepare urunc folder
+      - name: Prepare urunc folder
       id: prepare
-      run: |
+        run: |
         export GOROOT=$(go env GOROOT)
         export PATH="$GOROOT/bin:$PATH"
         go version
         go env GOROOT
         make prepare
-
-    - name: Run ${{ matrix.test }}
+      - name: Run ${{ matrix.test }}
       id: test
-      run: |
+        run: |
         # Set up Go environment properly
         export GOROOT=$(go env GOROOT)
         export PATH="$GOROOT/bin:$PATH"
@@ -398,10 +374,9 @@ jobs:
         else
           sudo -E env "PATH=$PATH" "GOROOT=$GOROOT" make ${{ matrix.test }}
         fi
-
-    - name: Dump urunc logs on failure
+      - name: Dump urunc logs on failure
       if: failure()
-      run: |
+        run: |
         echo "=== urunc debug logs ==="
         if command -v journalctl >/dev/null; then
           sudo journalctl --identifier=urunc --no-pager || true
