Skip to content

Commit b365dac

Browse files
committed
fix: Bring back the --all flag of kill
The shim uses the --all flag in Kubernetes settings when calling the low level runtime. We previously removed this flag causing issues in the deletion path of the pod. Therefore, we need to bring it back. PR: #717 Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
1 parent 0233433 commit b365dac

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

cmd/urunc/kill.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,13 @@ For example, if the container id is "ubuntu01" the following will send a "KILL"
4141
signal to the init process of the "ubuntu01" container:
4242
4343
# urunc kill ubuntu01 KILL`,
44+
Flags: []cli.Flag{
45+
&cli.BoolFlag{
46+
Name: "all",
47+
Aliases: []string{"a"},
48+
Usage: "send the specified signal to all processes inside the container",
49+
},
50+
},
4451
Action: func(_ context.Context, cmd *cli.Command) error {
4552
runtime.GOMAXPROCS(1)
4653
runtime.LockOSThread()

0 commit comments

Comments
 (0)