fix(unikontainers): lowercase error strings to follow Go conventions

PR: #707
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>

Author: mdryaan

pkg/unikontainers/block.go

@@ -130,7 +130,7 @@ func extractBootFiles(rootfsPath string, newRootfsPath string, unikernel string,
 	targetUnikernelDir, _ := filepath.Split(targetUnikernelPath)
 	err := moveFile(currentUnikernelPath, targetUnikernelDir)
 	if err != nil {
-		return fmt.Errorf("Could not move %s to %s: %w", currentUnikernelPath, targetUnikernelPath, err)
+		return fmt.Errorf("could not move %s to %s: %w", currentUnikernelPath, targetUnikernelPath, err)
 	}
 
 	if initrd != "" {
@@ -139,14 +139,14 @@ func extractBootFiles(rootfsPath string, newRootfsPath string, unikernel string,
 		targetInitrdDir, _ := filepath.Split(targetInitrdPath)
 		err = moveFile(currentInitrdPath, targetInitrdDir)
 		if err != nil {
-			return fmt.Errorf("Could not move %s to %s: %w", currentInitrdPath, targetInitrdPath, err)
+			return fmt.Errorf("could not move %s to %s: %w", currentInitrdPath, targetInitrdPath, err)
 		}
 	}
 
 	currentConfigPath := filepath.Join(rootfsPath, uruncJSON)
 	err = moveFile(currentConfigPath, newRootfsPath)
 	if err != nil {
-		return fmt.Errorf("Could not move %s to %s: %w", currentConfigPath, newRootfsPath, err)
+		return fmt.Errorf("could not move %s to %s: %w", currentConfigPath, newRootfsPath, err)
 	}
 
 	return nil

pkg/unikontainers/mount.go

@@ -220,7 +220,7 @@ func fileFromHost(monRootfs string, hostPath string, target string, mFlags int,
 		flags := mFlags | unix.MS_BIND | unix.MS_REMOUNT
 		err = unix.Mount(dstPath, dstPath, "", uintptr(flags), "")
 		if err != nil {
-			return fmt.Errorf("Failed to set mount flags for %s: %w", dstPath, err)
+			return fmt.Errorf("failed to set mount flags for %s: %w", dstPath, err)
 		}
 	}
 
@@ -298,7 +298,7 @@ func rootfsParentMountPrivate(path string) error {
 		path = filepath.Dir(path)
 	}
 
-	return fmt.Errorf("Could not remount as private the parent mount of %s", path)
+	return fmt.Errorf("could not remount as private the parent mount of %s", path)
 }
 
 // prepareRoot prepares the directory of the container's rootfs to safely pivot
@@ -368,7 +368,7 @@ func mountVolumes(rootfsPath string, mounts []specs.Mount) error {
 		for _, pFlag := range propFlag {
 			err = unix.Mount(dstPath, dstPath, "", uintptr(pFlag), "")
 			if err != nil {
-				return fmt.Errorf("Failed to set propagation flag for %s: %w", m.Source, err)
+				return fmt.Errorf("failed to set propagation flag for %s: %w", m.Source, err)
 			}
 		}
 	}

pkg/unikontainers/shared_fs.go

@@ -60,7 +60,7 @@ func (s sharedfsRootfs) postSetup() error {
 		// Get the virtiofsd binary from host in monRootfs
 		err = fileFromHost(s.monRootfs, s.vfsdConfig.Path, "", unix.MS_BIND|unix.MS_PRIVATE, false)
 		if err != nil {
-			return fmt.Errorf("Could not bind mount %s: %w", s.vfsdConfig.Path, err)
+			return fmt.Errorf("could not bind mount %s: %w", s.vfsdConfig.Path, err)
 		}
 	}
 

pkg/unikontainers/unikernels/rumprun.go

@@ -73,7 +73,7 @@ func (r *Rumprun) CommandString() (string, error) {
 	}
 	cmdJSON, err := json.Marshal(cmd)
 	if err != nil {
-		return "", fmt.Errorf("Could not Marshal cmdline: %v", err)
+		return "", fmt.Errorf("could not marshal cmdline: %v", err)
 	}
 	cmdJSONString = string(cmdJSON)
 	for i, eVar := range r.Envs {
@@ -82,7 +82,7 @@ func (r *Rumprun) CommandString() (string, error) {
 		}
 		oneVarJSON, err := json.Marshal(eVar)
 		if err != nil {
-			return "", fmt.Errorf("Could not Marshal environment variable: %v", err)
+			return "", fmt.Errorf("could not marshal environment variable: %v", err)
 		}
 		if i != 0 {
 			envJSONString += ","

pkg/unikontainers/utils.go

@@ -259,7 +259,7 @@ func findNS(namespaces []specs.LinuxNamespace, nsType specs.LinuxNamespaceType)
 		}
 	}
 
-	return "", fmt.Errorf("Namespace %s was not found", string(nsType))
+	return "", fmt.Errorf("namespace %s was not found", string(nsType))
 }
 
 // findQemuDataDir tries to find the location of data and BIOS files for Qemu.