fix: Bring back the --all flag of kill#717
Merged
Merged
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
force-pushed
the
fix_signal_handling
branch
from
98fd4e3 to
50e4fbc
Compare
cmainas
force-pushed
the
fix_signal_handling
branch
from
50e4fbc to
355418b
Compare
The shim uses the --all flag in Kubernetes settings when calling the low level runtime. We previously removed this flag causing issues in the deletion path of the pod. Therefore, we need to bring it back. PR: #717 Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
github-actions
Bot
force-pushed
the
fix_signal_handling
branch
from
355418b to
b365dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The shim uses the
--allflag in Kubernetes settings when calling the low level runtime. We previously removed this flag causing issues in the deletion path of the pod. Therefore, we need to bring it back.Related issues
How was this tested?
In a kubernetes single node cluster deployed a urunc container and then removed it.
Before the fix, the pod was staying as Terminating forever. With this fix the pod is getting removed correctly.
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).