Skip to content

Commit 41c9238

Browse files
ci: correct readiness comment and render missing telemetry as n/a
The BUILDKITD_READY_MAX_MS comment described the gated window as "buildkitd version" to "Found N workers", but the telemetry actually measures from buildkitd launch until the OCI worker is registered. Reword the comment to match what is measured. Also render the readiness value as "n/a (no telemetry line found)" when the target job has no telemetry line (older action versions) instead of printing a misleading "MISSINGms" in both the console line and the step summary table. Gating logic is unchanged; this is output-only. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
1 parent 978b795 commit 41c9238

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

.github/workflows/step-duration-regression.yml

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ on:
1414

1515
env:
1616
STEP_MAX_SECONDS: "5"
17-
# Hard ceiling for the buildkitd readiness window (time from
18-
# "buildkitd version" to "Found N workers"). Dominated by buildkitd's
19-
# own OCI-worker init; we want to catch a regression of either the
20-
# action's polling backoff or buildkitd warm-up itself.
17+
# Hard ceiling for the buildkitd readiness window reported by the action
18+
# (from buildkitd launch until the OCI worker is registered). Dominated by
19+
# buildkitd's own OCI-worker init; we want to catch a regression of either
20+
# the action's polling backoff or buildkitd warm-up itself.
2121
BUILDKITD_READY_MAX_MS: "8000"
2222
SETUP_STEP_NAME: "Setup Docker Builder under test"
2323

@@ -126,10 +126,19 @@ jobs:
126126
fi
127127
fi
128128
129+
# Render the readiness value, distinguishing a real measurement
130+
# from the older-action-version case where no telemetry line exists
131+
# (so the output doesn't show a misleading "MISSINGms").
132+
if [[ "$ready_ms" == "MISSING" ]]; then
133+
ready_display="n/a (no telemetry line found)"
134+
else
135+
ready_display="${ready_ms}ms in ${ready_polls} poll(s)"
136+
fi
137+
129138
echo ""
130139
echo "Setup step (\"${setup_name}\"): ${setup_duration}s (threshold ${MAX_SECONDS}s)"
131140
echo "Post step (\"${post_name}\"): ${post_duration}s (threshold ${MAX_SECONDS}s)"
132-
echo "buildkitd readiness: ${ready_ms}ms in ${ready_polls} poll(s) (threshold ${MAX_READY_MS}ms)"
141+
echo "buildkitd readiness: ${ready_display} (threshold ${MAX_READY_MS}ms)"
133142
134143
{
135144
echo "## Step Durations"
@@ -138,7 +147,7 @@ jobs:
138147
echo "|---|---:|---:|"
139148
echo "| Setup step (\`${setup_name}\`) | **${setup_duration}s** | ${MAX_SECONDS}s |"
140149
echo "| Post step (\`${post_name}\`) | **${post_duration}s** | ${MAX_SECONDS}s |"
141-
echo "| buildkitd readiness (polled) | **${ready_ms}ms** in ${ready_polls} poll(s) | ${MAX_READY_MS}ms |"
150+
echo "| buildkitd readiness (polled) | **${ready_display}** | ${MAX_READY_MS}ms |"
142151
} >> "$GITHUB_STEP_SUMMARY"
143152
144153
fail=0

0 commit comments

Comments
 (0)