log buildkitd worker readiness wait duration in setup step#114
Open
ajwerner wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The time spent waiting for buildkitd workers to become ready was only reported as a backend metric (
BPA_BUILDKITD_READY_DURATION_MS), invisible in the job log. This adds the elapsed wait to the existing "Found N workers" log line instartAndConfigureBuildkitd, so users can see how long the daemon took to come up directly in the setup step output:Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled. (Staging)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.