🔧 Refactor oneline parser warning logging and enhance CLI output

Author: patdhlk

src/sphinx_codelinks/analyse/analyse.py

@@ -207,13 +207,6 @@ def extract_oneline_need(
                     resolved.sub_type.value,
                 )
                 self.oneline_warnings.append(warning)
-                logger.warning(
-                    "Oneline parser warning in %s:%d - %s: %s",
-                    src_comment.source_file.filepath,
-                    lineno,
-                    resolved.sub_type.value,
-                    resolved.msg,
-                )
                 row_offset += 1
                 continue
             yield resolved, row_offset

src/sphinx_codelinks/cmd.py

@@ -56,7 +56,7 @@
 
 
 @app.command(no_args_is_help=True)
-def analyse(
+def analyse(  # noqa: PLR0912
     config: Annotated[
         Path,
         typer.Argument(
@@ -151,6 +151,15 @@ def analyse(
     codelinks_config.projects = specifed_project_configs
     analyse_projects = AnalyseProjects(codelinks_config)
     analyse_projects.run()
+
+    # Output warnings to console for CLI users
+    for src_analyse in analyse_projects.projects_analyse.values():
+        for warning in src_analyse.oneline_warnings:
+            logger.warning(
+                f"Oneline parser warning in {warning.file_path}:{warning.lineno} "
+                f"- {warning.sub_type}: {warning.msg}",
+            )
+
     analyse_projects.dump_markers()
 
 

tests/test_analyse.py

@@ -1,6 +1,5 @@
 # @Test suite for source code analysis and marker extraction, TEST_ANA_1, test, [IMPL_LNK_1, IMPL_ONE_1, IMPL_MRST_1]
 import json
-import logging
 from pathlib import Path
 
 import pytest
@@ -144,9 +143,8 @@ def test_analyse_oneline_needs(
     assert cnt_comments == result["num_comments"]
 
 
-def test_oneline_parser_warning_is_logged(tmp_path, caplog):
-    """Test that oneline parser warnings are logged to the console."""
-
+def test_oneline_parser_warnings_are_collected(tmp_path):
+    """Test that oneline parser warnings are collected for later output."""
     src_dir = TEST_DIR / "data" / "oneline_comment_default"
     src_paths = [src_dir / "default_oneliners.c"]
 
@@ -159,27 +157,11 @@ def test_oneline_parser_warning_is_logged(tmp_path, caplog):
         oneline_comment_style=ONELINE_COMMENT_STYLE_DEFAULT,
     )
 
-    # Ensure the logger propagates to root so caplog can capture it
-    analyse_logger = logging.getLogger("sphinx_codelinks.analyse.analyse")
-    original_propagate = analyse_logger.propagate
-    analyse_logger.propagate = True
-
-    try:
-        with caplog.at_level(
-            logging.WARNING, logger="sphinx_codelinks.analyse.analyse"
-        ):
-            src_analyse = SourceAnalyse(src_analyse_config)
-            src_analyse.run()
-
-        # Verify that warnings were collected
-        assert len(src_analyse.oneline_warnings) == 1
-
-        # Verify that the warning was logged
-        warning_records = [
-            r for r in caplog.records if "Oneline parser warning" in r.message
-        ]
-        assert len(warning_records) >= 1
-        assert "too_many_fields" in warning_records[0].message
-    finally:
-        # Restore original propagate setting
-        analyse_logger.propagate = original_propagate
+    src_analyse = SourceAnalyse(src_analyse_config)
+    src_analyse.run()
+
+    # Verify that warnings were collected
+    assert len(src_analyse.oneline_warnings) == 1
+    warning = src_analyse.oneline_warnings[0]
+    assert "too_many_fields" in warning.sub_type
+    assert warning.lineno == 17

tests/test_cmd.py

@@ -67,6 +67,43 @@ def test_analyse(config_path: Path, tmp_path: Path) -> None:
     assert marked_content
 
 
+def test_analyse_outputs_warnings(tmp_path: Path) -> None:
+    """Test that the analyse CLI command outputs warnings to console."""
+    # Create a config file that will produce warnings
+    src_dir = TEST_DIR / "data" / "oneline_comment_default"
+    config_dict = {
+        "codelinks": {
+            "outdir": str(tmp_path),
+            "projects": {
+                "test_project": {
+                    "source_discover": {
+                        "src_dir": str(src_dir),
+                        "include": ["*.c"],
+                        "comment_type": "cpp",
+                    },
+                    "analyse": {
+                        "get_oneline_needs": True,
+                        # Use default oneline_comment_style which will cause warnings
+                        # for the test file with too many fields
+                    },
+                }
+            },
+        }
+    }
+
+    config_file = tmp_path / "test_config.toml"
+    with config_file.open("w", encoding="utf-8") as f:
+        toml.dump(config_dict, f)
+
+    options: list[str] = ["analyse", str(config_file)]
+    result = runner.invoke(app, options)
+
+    assert result.exit_code == 0
+    # Verify that warnings are output to console
+    assert "Oneline parser warning" in result.output
+    assert "too_many_fields" in result.output
+
+
 @pytest.mark.parametrize(
     ("options", "stdout"),
     [