Support C-Sharp source tracing#34
Merged
Merged
Conversation
Contributor
Author
|
@juiwenchen let me know if smth else needs to be done |
juiwenchen
reviewed
Sep 23, 2025
Contributor
There was a problem hiding this comment.
Thanks for the PR!
It would be nice to have TCs for C-sharp parser in
https://github.com/useblocks/sphinx-codelinks/blob/main/tests/test_analyse_utils.py
There are TCs for cpp and python as the template. If you don't have enough time for it, I can do it.
| "typer>=0.16.0", | ||
| "click < 8.2", # click 8.2.* produces empty errors if no args are given | ||
| "click < 8.2", | ||
| # click 8.2.* produces empty errors if no args are given |
Contributor
There was a problem hiding this comment.
This seems a unnecessary change, and it's probably autoformatted by your dev tool.
Same for lineno 22 and 26
Contributor
Author
There was a problem hiding this comment.
yes, I think so. This happend when I added treesitter-c-sharp via rye add
Add tests for c-sharp Add language-specific node type mapping: created a SCOPE_NODE_TYPES dict that maps each CommentType to its appropriate AST node type. Made functions language aware and preserve backwards compatibility with using cpp as the default comment type
juiwenchen
approved these changes
Sep 23, 2025
Contributor
juiwenchen
left a comment
juiwenchen
left a comment
There was a problem hiding this comment.
Gooood work! Thanks for your PR
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32