🐛 Fix trailing separator in string_links for single-value fields

When a string_links field contained a single value, a trailing separator
"; " was incorrectly rendered because len(data) checked the string
length instead of the list length. Changed to len(data_list).

Added a regression test that verifies single-value string_links fields
render without a trailing separator.

Author: floroks

sphinx_needs/layout.py

@@ -546,7 +546,7 @@ def meta(
                     data_node += ref_item
 
                 if (
-                    name in needs_string_links_option and index + 1 < len(data)
+                    name in needs_string_links_option and index + 1 < len(data_list)
                 ) or index + 1 < len([data]):
                     data_node += nodes.emphasis("; ", "; ")
 

tests/doc_test/doc_needtable/test_options.rst

@@ -19,6 +19,12 @@ TEST OPTIONS
 
    Replaces the string from ``:config:`` and ``:github:`` with a link to the related website.
 
+.. spec:: Single value string_link
+   :id: SINGLE_STRING_LINK
+   :github: 404
+
+   A need with a single-value string_links field to verify no trailing separator is rendered.
+
 
 table 1
 --------

tests/test_needtable.py

@@ -110,6 +110,49 @@ def test_doc_needtable_options(test_app):
     assert string_column_order in html
 
 
+@pytest.mark.parametrize(
+    "test_app",
+    [{"buildername": "html", "srcdir": "doc_test/doc_needtable"}],
+    indirect=True,
+)
+def test_string_links_no_trailing_separator(test_app):
+    """Test that single-value string_links fields don't get a trailing separator."""
+    app = test_app
+    app.build()
+    html = Path(app.outdir, "test_options.html").read_text()
+
+    # Find the SINGLE_STRING_LINK need's github cell content
+    assert "SINGLE_STRING_LINK" in html
+    assert (
+        '<a class="reference external" href="https://github.com/useblocks/sphinxcontrib-needs/issues/404">'
+        "GitHub #404</a>" in html
+    )
+
+    # The single-value field should NOT have a trailing "; " separator.
+    # Before the fix, len(data) was used instead of len(data_list), causing
+    # a trailing separator for any string value longer than 1 character.
+    from lxml import html as html_parser
+
+    tree = html_parser.parse(str(Path(app.outdir, "test_options.html")))
+
+    # Find the need card/layout for SINGLE_STRING_LINK and check its github field
+    # In the need layout, string_links values are rendered inside <span class="needs_data">
+    # We look for the github content in the SINGLE_STRING_LINK need
+    single_need_elements = tree.xpath(
+        '//*[@id="SINGLE_STRING_LINK"]//span[@class="needs_data"]'
+    )
+    for elem in single_need_elements:
+        text_content = elem.text_content()
+        if "GitHub #404" in text_content:
+            # Should contain exactly "GitHub #404" with no trailing "; "
+            assert text_content.strip() == "GitHub #404", (
+                f"Expected no trailing separator, got: {text_content!r}"
+            )
+            break
+    else:
+        pytest.fail("Could not find GitHub #404 in SINGLE_STRING_LINK need layout")
+
+
 @pytest.mark.parametrize(
     "test_app",
     [{"buildername": "html", "srcdir": "doc_test/doc_needtable"}],