🧪 Add schema config fixtures for invalid $ref value cases#1733
Merged
Conversation
Cover the two remaining `$ref` config-error branches in `resolve_refs` that lacked fixtures: a `$ref` value that is not a string, and a `$ref` that does not start with `#/$defs/`. These serve as the parity oracle for the equivalent ubcode checks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
==========================================
+ Coverage 86.87% 89.37% +2.49%
==========================================
Files 56 72 +16
Lines 6532 10549 +4017
==========================================
+ Hits 5675 9428 +3753
- Misses 857 1121 +264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ubmarco
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two
test_schema_configfixtures covering the$refconfig-error branches inresolve_refsthat previously had no fixture:ref_value_not_string— a$refwhose value is not a string ($ref: 123) →Invalid $ref value: 123, expected a string.ref_not_defs_prefix— a$refthat does not start with#/$defs/($ref: "type-impl") →Invalid $ref value: type-impl, expected to start with '#/$defs/'.These complete the fixture coverage of
resolve_refs' error cases (alongside the existing missing-target / sibling-key / circular fixtures) and serve as the parity oracle for the equivalent checks in ubcode's faithfulresolve_refsport.Test-only; no behavior change.