🧪 Add network-local reduction parity fixtures#1734
Merged
Conversation
Add two schema-validation fixtures exercising a network-context `local`
schema that uses `unevaluatedProperties`:
- `network_local_unevaluated_reduced_ok`: a linked spec with no extra
fields, reduced to just `{type: spec}`, validates cleanly — confirming
`_validate_need_local` applies `reduce_need` inside the network path as
it does for top-level local validation.
- `network_local_unevaluated_reduced_error`: the linked spec sets an
extra `asil` field the schema does not reference; reduction keeps it, so
`unevaluatedProperties: false` still fails — confirming reduction does
not mask real violations.
These pin the existing behaviour as an oracle for the ubcode port.
ubmarco
approved these changes
Jun 30, 2026
ubmarco
left a comment
ubmarco
left a comment
Member
There was a problem hiding this comment.
What would I have to say against more testing?!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1734 +/- ##
==========================================
+ Coverage 86.87% 89.37% +2.49%
==========================================
Files 56 72 +16
Lines 6532 10549 +4017
==========================================
+ Hits 5675 9428 +3753
- Misses 857 1121 +264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two schema-validation fixtures that pin sphinx-needs' behaviour for a network-context
localschema usingunevaluatedProperties, to serve as the parity oracle for the ubcode port.network_local_unevaluated_reduced_ok— a linked spec with no extra fields, reduced to just{type: spec}, validates cleanly. Confirms_validate_need_localappliesreduce_needinside the network path exactly as for top-level local validation.network_local_unevaluated_reduced_error— the linked spec sets an extraasilfield the schema does not reference; reduction keeps actively-set extra fields, sounevaluatedProperties: falsestill fails. Confirms reduction does not mask real violations.No behaviour change — fixtures + snapshots only.