🧪 Add multi-error network-local parity fixture#1735
Merged
Conversation
Add `network_local_multi_error`: a network-context `local` whose linked target violates two property `const` constraints at once. `_validate_need_local` lists ALL of `iter_errors` (one warning per error), so both the `asil` and `comment` failures on SPEC_1 are reported. Pins that behaviour as the oracle for the ubcode port, whose network-local path surfaces only the first error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
+ Coverage 86.87% 89.37% +2.49%
==========================================
Files 56 72 +16
Lines 6532 10549 +4017
==========================================
+ Hits 5675 9428 +3753
- Misses 857 1121 +264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ubmarco
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
network_local_multi_error— a network-contextlocalwhose linked target (SPEC_1) violates two propertyconstconstraints at once (asilandcomment)._validate_need_localcollects all ofiter_errors(oneOntologyWarningper error), so both failures are reported. This pins that behaviour as the parity oracle for the ubcode port, whose network-local path currently surfaces only the first error (the remaining half of the #1461-style "condense network local errors" divergence).No behaviour change — fixture + snapshot only.