fix: correct misspellings (occurred, environments, separator/separated)#7933
fix: correct misspellings (occurred, environments, separator/separated)#7933renatograsso10 wants to merge 1 commit into
Conversation
renatograsso10
requested review from
bijin-bruno,
helloanoop,
lohit-bruno,
naman-bruno and
sid-bruno
as code owners
WalkthroughThis PR fixes several spelling mistakes across the codebase: CSS class selectors in a sidebar component, log messages in two Electron modules, and a test description. It also adds a new unit test asserting that list items on the same line are invalid. ChangesTypo Fixes and Test Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/bruno-lang/v2/tests/list.spec.js (1)
191-201: 💤 Low valueTest description could be more precise.
The description "list items are not separated by at least one newline" is misleading —
tag_1andtag_2are newline-separated in the fixture. The actual violation istag_2andtag_3appearing on the same line. A clearer name would be'should fail when two list items appear on the same line'.✏️ Suggested rename
- it('should fail when list items are not separated by at least one newline', () => { + it('should fail when two list items appear on the same line', () => {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/bruno-lang/v2/tests/list.spec.js` around lines 191 - 201, The test description for the unit using parser(input) is misleading: update the it(...) title from "should fail when list items are not separated by at least one newline" to a clearer description like "should fail when two list items appear on the same line" so it accurately reflects the failure condition in the test that tag_2 and tag_3 are on the same line; locate the it(...) call in list.spec.js and change only the string argument to the new wording.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/bruno-lang/v2/tests/list.spec.js`:
- Around line 191-201: The test description for the unit using parser(input) is
misleading: update the it(...) title from "should fail when list items are not
separated by at least one newline" to a clearer description like "should fail
when two list items appear on the same line" so it accurately reflects the
failure condition in the test that tag_2 and tag_3 are on the same line; locate
the it(...) call in list.spec.js and change only the string argument to the new
wording.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 60675cd2-fb6a-45e7-b78d-919bc8901254
📒 Files selected for processing (4)
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.jspackages/bruno-electron/src/app/collection-watcher.jspackages/bruno-electron/src/ipc/preferences.jspackages/bruno-lang/v2/tests/list.spec.js
- packages/bruno-electron/src/app/collection-watcher.js: "occured" -> "occurred" - packages/bruno-electron/src/ipc/preferences.js: "occured" -> "occurred", "environements" -> "environments" - packages/bruno-app/.../CollectionItem/StyledWrapper.js: ".item-seperator" / ".seperator" -> ".item-separator" / ".separator" (no other refs to these CSS class names exist in the repo) - packages/bruno-lang/v2/tests/list.spec.js: test description "list item are not seperated by atleast" -> "list items are not separated by at least" (29 tests still pass)
|
Tip For best results, initiate chat on the files or code changes.
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.js (1)
118-126:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove the unused
item-separatorCSS rule or confirm it's intended for future use.The CSS selector was corrected but no component in the codebase applies the
item-separatorclass. The rule is dead code unless it's being reserved for future implementation. Either clean it up or document why it's needed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.js` around lines 118 - 126, The .item-separator CSS rule inside StyledWrapper (the .item-separator selector and its nested .separator rule) appears unused; either remove that rule from StyledWrapper.js to eliminate dead CSS, or if it's intended, add a short comment above .item-separator explaining its purpose and where/components will apply it (or add the .item-separator class to the relevant component markup that should render the separator). Ensure you reference the .item-separator and .separator selectors when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.js`:
- Around line 118-126: The .item-separator CSS rule inside StyledWrapper (the
.item-separator selector and its nested .separator rule) appears unused; either
remove that rule from StyledWrapper.js to eliminate dead CSS, or if it's
intended, add a short comment above .item-separator explaining its purpose and
where/components will apply it (or add the .item-separator class to the relevant
component markup that should render the separator). Ensure you reference the
.item-separator and .separator selectors when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df8a33d4-020a-4b32-b1ab-2fb92fba2113
📒 Files selected for processing (4)
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.jspackages/bruno-electron/src/app/collection-watcher.jspackages/bruno-electron/src/ipc/preferences.jspackages/bruno-lang/v2/tests/list.spec.js
1 participant
Summary
Small typo fixes in error messages, test descriptions, and CSS class names.
Changes
packages/bruno-electron/src/app/collection-watcher.js—occured→occurredpackages/bruno-electron/src/ipc/preferences.js—occured→occurred,environements→environments(one console error message had both typos)packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/StyledWrapper.js—.item-seperator/.seperator→.item-separator/.separator. Verified viagit grepthat no other file references these class names, so the rename is self-contained.packages/bruno-lang/v2/tests/list.spec.js— test description:list item are not seperated by atleast one newline→list items are not separated by at least one newlineTest plan
npx jest packages/bruno-lang/v2/tests/list.spec.js— 29 tests passgit grep -nwE 'occured|seperator|seperated|environements|atleast'returns no remaining occurrences inpackages/Summary by CodeRabbit
Style
Chores
Tests