Skip to content

Feat/playwright os 2#7941

Draft
bijin-bruno wants to merge 14 commits into
mainfrom
feat/playwright-os-2
Draft

Feat/playwright os 2#7941
bijin-bruno wants to merge 14 commits into
mainfrom
feat/playwright-os-2

Conversation

@bijin-bruno
Copy link
Copy Markdown
Collaborator

Description

Updated branch from #7253

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5c4d269c-551a-47b6-ab32-6af282b751c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/playwright-os-2

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

CLI Test Results (Linux)

  1 files  211 suites   1m 8s ⏱️
589 tests 589 ✅ 0 💤 0 ❌
702 runs  695 ✅ 7 💤 0 ❌

Results for commit f60f3e4.

♻️ This comment has been updated with latest results.

@bijin-bruno bijin-bruno force-pushed the feat/playwright-os-2 branch from 1581a7b to 811419d Compare May 7, 2026 19:39
@bijin-bruno bijin-bruno force-pushed the feat/playwright-os-2 branch 2 times, most recently from 11d50f8 to 6b739f8 Compare May 8, 2026 08:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

⚠️ Warning: You modified flaky/failed test files

The following test files you modified have reliability issues:

❌ Failed: tests/import/insomnia/import-insomnia-v5-environments.spec.ts

Test: Import Insomnia v5 collection with nested environments and verify flattening
Status: failed

To debug locally, run:

npx playwright test tests/import/insomnia/import-insomnia-v5-environments.spec.ts --repeat-each=5 --workers=1

❌ Failed: tests/shortcuts/bound-actions.spec.ts

Test: default Cmd/Ctrl+W closes the active tab
Status: failed

To debug locally, run:

npx playwright test tests/shortcuts/bound-actions.spec.ts --repeat-each=5 --workers=1

⚠️ Flaky: tests/shortcuts/bound-actions.spec.ts

Test: default Cmd/Ctrl+F open sidebar search
Status: passed
Retry Attempt: 1

To debug locally, run:

npx playwright test tests/shortcuts/bound-actions.spec.ts --repeat-each=5 --workers=1

⚠️ Flaky: tests/shortcuts/bound-actions.spec.ts

Test: customized Alt+K Global Search Modal
Status: passed
Retry Attempt: 1

To debug locally, run:

npx playwright test tests/shortcuts/bound-actions.spec.ts --repeat-each=5 --workers=1

❌ Failed: tests/shortcuts/bound-actions.spec.ts

Test: sends request when cursor is in pre-request Vars value editor
Status: failed

To debug locally, run:

npx playwright test tests/shortcuts/bound-actions.spec.ts --repeat-each=5 --workers=1

Note: Flaky tests passed after retrying, failed tests did not pass. Please investigate and fix the root cause before merging.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these tests removed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those assertions would fail on windows. Also, doesn't provide much value since all of them are validating an external module path. Few validations that are remaining is enough to validate the bruno scripting.

Comment thread tests/environments/api-setEnvVar/multiple-persist-vars.spec.ts
Comment thread tests/workspace/default-workspace/migration.spec.ts Outdated
@bijin-bruno bijin-bruno force-pushed the feat/playwright-os-2 branch from a44b6b5 to 980b20c Compare May 11, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants