Skip to content

Oversight in dependency version for firebase/php-jwt #113

@wavedeck

Description

@wavedeck

According to composer.json, the dependency firebase/php-jwt is allowed to update implicitly until the last minor version of the current major (v6.x).

However, this would actually negate the mentioned minimum required PHP version (7.2) as described in the plugin README.

Starting with v6.5, php-jwt increased the minimum supported PHP version to 7.4 php-jwt@6.5.0 on packagist

in the PR #112 , i noticed this and tried to mitigate it by only allowing patch releases within the current declared minor. This change was reverted in favor of discussing this beforehand.

Imho we have two different options, either, keep / update the current dependency version in composer.json and raise the minimum required PHP version of this plugin to 7.4 or lock the dependency version to patch-releases within v6.3 / v6.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions