Commit 54a3cd1
fix(client): address close() review follow-ups (#1075)
* fix(client): address close() review follow-ups
- subscription_info now rejects on a closed client (raising the same 'client is
closed' error every other surface enforces) instead of returning stale
'Unknown' tiers, which hid the closed state.
- Correct the TypeScript close() docstring: close() joins the dispatcher (so it
can block briefly on an in-flight callback) but does not run the awaitDrain
ring barrier — that is the async-disposer path.
- Fix a typo (survivng -> surviving).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* build(ts): regenerate index.d.ts for the corrected close() doc (and refresh the stale rc.5 version guard)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(ts): pin platform native packages to rc.13 in the lockfile
The regenerated index.js enforces native binding 13.0.0-rc.13, but the
lockfile still resolved thetadatadx-darwin-arm64, thetadatadx-linux-x64-gnu,
and thetadatadx-win32-x64-msvc at 13.0.0-rc.5. An npm ci honoring the
lockfile would install the older native and either trip the enforced
version check or run an unexpected native. Align the three resolved
entries to rc.13 with their published integrity.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: preview <noreply@anthropic.com>1 parent 10869b2 commit 54a3cd1
6 files changed
Lines changed: 87 additions & 86 deletions
File tree
- thetadatadx-py/src
- thetadatadx-ts
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
689 | 689 | | |
690 | 690 | | |
691 | 691 | | |
692 | | - | |
| 692 | + | |
693 | 693 | | |
694 | 694 | | |
695 | 695 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
293 | 288 | | |
294 | 289 | | |
295 | 290 | | |
296 | 291 | | |
297 | | - | |
| 292 | + | |
298 | 293 | | |
299 | 294 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments