chore(fpss): remove dead wait-strategy escape hatch + hand-rolled splitmix#1200
Merged
Conversation
… splitmix for_each_with_wait_strategy<W> and its streaming::wait re-export module had no caller but their own test — a public generic that can't cross the FFI and that the bindings never use (they drain through for_each_scoped). Remove the method, the re-export, and the test. seeded_cursor drew its offset from a hand-rolled entropy_u64/splitmix64; use the already-imported rand instead and delete both functions. No behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the engine-vs-terminal audit. Dead / redundant internal code, no behavior change, no cross-binding surface touched.
for_each_with_wait_strategy<W>+ thestreaming::waitre-export (BusySpin/Sleep/WaitStrategy) had no caller but their own test — a public generic that cannot cross the FFI, so no binding could ever use it; the bindings drain viafor_each_scoped. Removed method, module, and test.seeded_cursorused a hand-rolledentropy_u64/splitmix64; switched to the already-importedrand. Both functions deleted.Verified: rust lib 1064 tests pass; clippy -D warnings clean; Python/TypeScript clippy clean.