fix(mcp): add all missing fields to quote, trade-quote, and Greeks serializers#229
Merged
Conversation
…rializers QuoteTick: add bid_condition, ask_condition, midpoint (#213) TradeQuoteTick: add quote_ms_of_day, bid_exchange, ask_exchange, bid_condition, ask_condition, ext_condition1-4, condition_flags, price_flags, volume_type, records_back (#214) GreeksTick: add all 15 second-order Greeks (vanna, charm, vomma, veta, speed, zomma, color, ultima, d1, d2, dual_delta, dual_gamma, epsilon, lambda, vera) (#215) MCP serializers now emit the same field set as the REST server. Fixes #213, fixes #214, fixes #215 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP tick serializers were silently dropping fields that the REST server and CLI include:
bid_condition,ask_condition,midpointquote_ms_of_day,bid_exchange,ask_exchange,bid_condition,ask_condition,ext_condition1-4,condition_flags,price_flags,volume_type,records_backvanna,charm,vomma,veta,speed,zomma,color,ultima,d1,d2,dual_delta,dual_gamma,epsilon,lambda,vera)Fixes #213, fixes #214, fixes #215
Test plan
cargo fmt --all -- --checkcleancargo clippy --manifest-path tools/mcp/Cargo.toml -- -D warningscleancargo test --workspacepasses (242 tests)option_history_greeks_allreturns 22+ fields per tickstock_history_quotereturnsbid_condition/ask_condition🤖 Generated with Claude Code