fix(build): parse TOML+proto once, add EndpointError impls, rename tick schema#230
Merged
Conversation
…ck schema Three fixes in the core crate: 1. Call load_endpoint_specs() once in generate_all() and pass the result to all three generators instead of re-parsing TOML+proto 3 times per build. (#211) 2. Add Display and std::error::Error impls to EndpointError so consumers can log/format it without pattern matching. (#219) 3. Rename endpoint_schema.toml → tick_schema.toml to disambiguate from endpoint_surface.toml. Updated all code and doc references. (#220) Fixes #211, fixes #219, fixes #220 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e-hiding (#221) The doc, copy, and align fields in tick_schema.toml exist for documentation and FFI layout hints but aren't consumed by the parser generator. Replace the _rename trick with #[allow(dead_code)] and a doc comment explaining why they exist. Fixes #221 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_endpoint_specs()was called 3 times per build (once per generator). Now called once ingenerate_all()and passed by reference. (perf(build): endpoint_surface.toml + proto parsed 3 times per build #211)?,format!(),tracing::error!()onEndpointErrorwithout pattern matching. (fix(endpoint): EndpointError lacks Display and std::error::Error impls #219)endpoint_schema.toml→tick_schema.tomlto disambiguate fromendpoint_surface.toml. All code and doc references updated. (chore(build): rename endpoint_schema.toml to tick_schema.toml to avoid confusion #220)Fixes #211, fixes #219, fixes #220
Test plan
cargo fmt --all -- --checkcleancargo clippy --workspace --all-targets -- -D warningscleancargo test --workspacepasses (242 tests)🤖 Generated with Claude Code