Revert: restore TdxSnapshotTradeTick in C++ SDK#237
Merged
Conversation
Restores TdxSnapshotTradeTick to the C++ SDK. The struct is not dead — it mirrors the Rust SnapshotTradeTick type used for snapshot trade endpoints. It was missing FFI plumbing (array type + free function), which should be added rather than deleting the struct. This reverts commit $(gh pr view 232 --json mergeCommit -q .mergeCommit.oid | head -c 7). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #232 which incorrectly removed
TdxSnapshotTradeTickfrom the C++ SDK header.The struct mirrors
tdbe::SnapshotTradeTickwhich IS used by snapshot trade endpoints. It was missing FFI array/free plumbing (tracked in #216), but the struct itself should stay. Wiring the FFI exports is a separate task.Reopens #227 (will be closed differently — by adding FFI plumbing instead of deleting the struct).
🤖 Generated with Claude Code