chore(build): replace hand-built ohlc_range with clone from wire model#240
Merged
Conversation
…wire model (#222) The stock_history_ohlc_range wire entry was a full 130-line hand-built GeneratedEndpoint duplicating fields/params already derivable from the stock_history_ohlc proto entry. Replace with a 4-line clone-and-rename that stays in sync automatically. The synthetic exclusion list and TOML surface spec are unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratedEndpointforstock_history_ohlc_rangeinload_proto_endpoints()with a 4-line clone from thestock_history_ohlcwire entryendpoint_surface.toml) carries the parameter differences viawire_name = "stock_history_ohlc"and its own templateload_endpoint_specs()is retained since the cloned wire entry still doesn't correspond to a unique proto RPCCloses #222
Test plan
cargo fmt --all -- --checkpassescargo test --workspacepasses (240 tests, includingstock_history_ohlc_range_exists)macros.rsare unrelated to this change (verified on main)🤖 Generated with Claude Code