fix(exchange): rename code 0 to Composite#477
Merged
Conversation
Code 0 was seeded from an upstream NxCore-style dictionary that embeds a peer-vendor product mark in the display name. The published vendor exchange table at docs.thetadata.us starts at code 1, so code 0 is internal-only and never user-visible. Use neutral SIP/CTA terminology (`Composite` / `COMP`) so the authored source carries no third-party product marks. Wire byte 0 still maps to the same array slot; symbol unchanged.
2 tasks
userFRM
added a commit
that referenced
this pull request
May 6, 2026
#477 (Composite rename) merged after the [8.0.26] section was drafted. Add the bullet under "Changed" so the release notes reflect everything that ships with v8.0.26.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the
namefield ofEXCHANGES[0]from a third-party product mark to neutral SIP terminology (Composite).Why
crates/tdbe/src/exchange.rs:17seeded code 0 from an upstream NxCore-style exchange dictionary that embeds a peer-vendor product mark. The published vendor exchange table at https://docs.thetadata.us/Articles/Errors-Exchanges-Conditions/Exchanges.html starts at code 1, so code 0 is internal-only and never appears in user-facing data. The authored source tree should not carry third-party product marks for an internal sentinel.How
name: "NanexComp"->name: "Composite". Symbol staysCOMP(already generic for the consolidated tape). Test assertion at:437updated to match. Array length unchanged (78); wire byte 0 still resolves to the same slot.Closes #476.
Test plan
cargo test -p tdbe exchange(5 tests pass)cargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkrg 'Nanex'returns no matches in tracked sources