fix(conditions): scrub third-party product mark from trade condition 61#480
Merged
Conversation
The display name carried a third-party product mark inherited from the
upstream condition dictionary. The description ("Used to make volume
and price corrections to match official exchange values") already
describes the purpose, so the renamed `PRICEVOLUMEADJ` constant
captures intent without the vendor reference. Single tracked
occurrence, no downstream string match.
This was referenced May 6, 2026
Merged
userFRM
added a commit
that referenced
this pull request
May 6, 2026
* chore(release): 8.0.27 - polars 0.52 -> 0.53 (#479) - conditions code 61 scrubbed to PRICEVOLUMEADJ (#480) * chore(release): refresh sub-Cargo.lock files for 8.0.27 The workspace bump only updated the root Cargo.lock; tools/mcp, tools/server, sdks/python, sdks/typescript carry their own lockfiles that pin thetadatadx by version. CI's --locked check failed because they still pinned 8.0.26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename trade condition 61's display name in
crates/tdbe/src/conditions.rs:825.Why
Condition 61's display name embeds a third-party product mark inherited from the upstream condition dictionary. Same pattern as #477 (exchange code 0). The description ("Used to make volume and price corrections to match official exchange values") already captures purpose; the renamed constant matches intent without the vendor reference.
How
"NANEXADMIN"->"PRICEVOLUMEADJ"(matches existing ALLCAPS condition-name convention). Single tracked-source occurrence, no downstream string match (rg 'NANEXADMIN'clean post-rename). Description unchanged.Test plan
cargo test -p tdbe conditions(18 tests pass)rg 'Nanex|NANEX'returns no matchescargo fmt --all -- --check