Skip to content

refactor(wave1): vocab + version refs + ParsedRight wire-up + json_canon fold + ADRs (refs #500)#501

Merged
userFRM merged 1 commit into
mainfrom
refactor/wave1-cleanup
May 7, 2026
Merged

refactor(wave1): vocab + version refs + ParsedRight wire-up + json_canon fold + ADRs (refs #500)#501
userFRM merged 1 commit into
mainfrom
refactor/wave1-cleanup

Conversation

@userFRM
Copy link
Copy Markdown
Owner

@userFRM userFRM commented May 6, 2026

Summary

Wave 1 of the audit-sweep refactor. Five low-risk, mechanical refactors bundled into one squashable commit. Version bumped 8.0.32 -> 8.0.33.

Per-item checklist

  • 1. Banned vocabulary firehose removed from source doc comments, README.md, and ROADMAP.md. Replaced with full-stream / full-type. CHANGELOG history intentionally untouched.

    • crates/thetadatadx/src/unified.rs (3 sites)
    • crates/thetadatadx/src/fpss/mod.rs (2 sites)
    • README.md, ROADMAP.md (4 sites total)
  • 2. Internal version refs removed from source comments (v8.0.10, v7.2.0, v8.0.3, v8.0.2, v6.0.1+). Semantic content preserved.

    • crates/thetadatadx/src/wire_semantics.rs:9
    • crates/thetadatadx/src/decode.rs:1734
    • crates/tdbe/benches/bench_tick.rs:9
    • crates/thetadatadx/build_support/ticks/python_arrow.rs:57
    • crates/thetadatadx/build_support/endpoints/render/python.rs:13,207,221
  • 3. ParsedRight::from_wire_byte wired at 4 magic-number sites in crates/tdbe/src/types/tick.rs. pub use crate::right::ParsedRight; added at the call site.

    • is_call / is_put macro impls (lines 31, 36)
    • OptionContract impls (lines 103, 108)
    • 127 tdbe tests pass.
  • 4. crates/json_canon folded into tdbe::json_canon. Workspace member removed; sonic-rs dep relocated to tdbe; all CLI / MCP / server callers updated.

  • 5. Seven ADRs added under docs/architecture/:

    • ADR-001 Java terminal parity sourcing
    • ADR-002 FPSS ring power-of-two capacity
    • ADR-003 MDDS 2^tier concurrent-request mapping
    • ADR-004 Eastern-time DST cutover
    • ADR-005 OCC-21 century scope (expires 2099-12-31)
    • ADR-006 FPSS reconnect policy
    • ADR-007 Flatfiles MDDS SPKI pin

Version bump output

canonical version (Cargo.toml): 8.0.33
version sync: ok
bumping 8.0.32 -> 8.0.33
  bumped crates/thetadatadx/Cargo.toml
  bumped ffi/Cargo.toml
  bumped tools/cli/Cargo.toml
  bumped tools/mcp/Cargo.toml
  bumped tools/server/Cargo.toml
  bumped sdks/python/Cargo.toml
  bumped sdks/typescript/Cargo.toml
  bumped sdks/typescript/package.json (+ optionalDependencies)
  bumped sdks/typescript/npm/{darwin-arm64,linux-x64-gnu,win32-x64-msvc}/package.json

python3 scripts/check_version_sync.py -> version sync: ok.

Final scrubs

  • rg -i firehose crates/ README.md ROADMAP.md -> zero hits
  • rg "from_wire_byte" crates/tdbe/src/types/tick.rs -> 4 hits (the 4 wired sites)
  • crates/json_canon/ -> directory removed, no workspace member
  • ls docs/architecture/ADR-00*.md | wc -l -> 7

Local gate

Command Status
cargo fmt --all -- --check yes
cargo clippy --workspace --all-targets -- -D warnings yes
cargo test --workspace yes
cargo deny check yes
cargo run -p thetadatadx --bin generate_sdk_surfaces --features config-file -- --check yes
cargo check --manifest-path tools/mcp/Cargo.toml --locked yes
cargo clippy --manifest-path tools/mcp/Cargo.toml --all-targets -- -D warnings yes
cargo test --manifest-path tools/mcp/Cargo.toml --no-run yes
cargo check --manifest-path tools/server/Cargo.toml --locked yes
cargo check --manifest-path sdks/python/Cargo.toml --locked yes
cargo check --manifest-path sdks/typescript/Cargo.toml --locked yes
python3 scripts/check_version_sync.py yes

Out of scope (deferred to follow-up dispatch)

The coordinator expanded scope mid-flight to bundle Wave 2 + Wave 3 + Wave 4 (breaking 9.0.0 cut) into the same PR. That expansion is genuinely a multi-session effort (god-file splits with import-fixup across the workspace, build.rs codegen migration for 2.7K-LoC condition tables, ArcSwap state-machine introduction with new transition tests, breaking surface removals cascading through ffi/python/typescript bindings). Per the coordinator's own guidance ("If this scope is genuinely too much for one session, complete what you can cleanly and surface what's left in the PR body"), this PR ships Wave 1 only as 8.0.33 and surfaces the remainder for a follow-up refactor/9.0.0-mega-cut dispatch:

  • Wave 2 decode.rs / fpss/protocol.rs / config.rs god-file splits; tdbe::time Eastern-time lift; tdbe/build.rs conditions codegen from TOML.
  • Wave 3 typed SubscriptionTier (2^tier semaphore); ArcSwap<StreamingSlot> 3-field collapse; layout moves under mdds/; unified.rs -> client.rs; frames/ and types/generated/ regrouping; LOW chores 3.1, 3.2, 3.5, 3.9, 3.10.
  • Wave 4 BREAKING (9.0.0 cut) B1 contract_map / contract_lookup removal; B2 pub mod proto -> pub(crate); B3 connection / framing / ring / dispatcher -> pub(crate); B4 FpssConnectArgs; B5 Contract::option IntoOptionSpec collapse.

DO NOT MERGE. DO NOT TAG.

Refs #500.

…non fold + ADRs (refs #500)

Bundle five low-risk, mechanical refactors:

1. Drop banned vocabulary "firehose" from source comments, README.md, and
   ROADMAP.md. Replace with "full-stream" / "full-type". CHANGELOG history
   is intentionally untouched.

2. Drop internal version references from source comments
   (`v8.0.10`, `v7.2.0`, `v8.0.3`, `v8.0.2`, `v6.0.1+`). Semantic content
   preserved; release metadata removed where it adds no maintenance value.

3. Wire `tdbe::right::ParsedRight::from_wire_byte` at the four
   `is_call` / `is_put` sites in `crates/tdbe/src/types/tick.rs`. The
   `right == 67` / `right == 80` magic-number comparisons go through the
   typed parser; behaviour is identical, the magic numbers are gone.

4. Fold `crates/json_canon` into `tdbe::json_canon`. Workspace member
   removed; `sonic-rs` dep moved to `tdbe`; CLI / MCP / server callers
   updated to `tdbe::json_canon::*`.

5. Add seven Architecture Decision Records under `docs/architecture/`:
   ADR-001 (Java terminal parity sourcing), ADR-002 (FPSS ring power-of-
   two capacity), ADR-003 (MDDS 2^tier concurrent-request mapping),
   ADR-004 (Eastern-time DST cutover), ADR-005 (OCC-21 century scope),
   ADR-006 (FPSS reconnect policy), ADR-007 (flatfiles MDDS SPKI pin).

Version bumped 8.0.32 -> 8.0.33 via scripts/bump_version.py.

Refs #500.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@userFRM userFRM merged commit a6f9a51 into main May 7, 2026
32 checks passed
@userFRM userFRM deleted the refactor/wave1-cleanup branch May 7, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant