refactor(wave1): vocab + version refs + ParsedRight wire-up + json_canon fold + ADRs (refs #500)#501
Merged
Merged
Conversation
…non fold + ADRs (refs #500) Bundle five low-risk, mechanical refactors: 1. Drop banned vocabulary "firehose" from source comments, README.md, and ROADMAP.md. Replace with "full-stream" / "full-type". CHANGELOG history is intentionally untouched. 2. Drop internal version references from source comments (`v8.0.10`, `v7.2.0`, `v8.0.3`, `v8.0.2`, `v6.0.1+`). Semantic content preserved; release metadata removed where it adds no maintenance value. 3. Wire `tdbe::right::ParsedRight::from_wire_byte` at the four `is_call` / `is_put` sites in `crates/tdbe/src/types/tick.rs`. The `right == 67` / `right == 80` magic-number comparisons go through the typed parser; behaviour is identical, the magic numbers are gone. 4. Fold `crates/json_canon` into `tdbe::json_canon`. Workspace member removed; `sonic-rs` dep moved to `tdbe`; CLI / MCP / server callers updated to `tdbe::json_canon::*`. 5. Add seven Architecture Decision Records under `docs/architecture/`: ADR-001 (Java terminal parity sourcing), ADR-002 (FPSS ring power-of- two capacity), ADR-003 (MDDS 2^tier concurrent-request mapping), ADR-004 (Eastern-time DST cutover), ADR-005 (OCC-21 century scope), ADR-006 (FPSS reconnect policy), ADR-007 (flatfiles MDDS SPKI pin). Version bumped 8.0.32 -> 8.0.33 via scripts/bump_version.py. Refs #500. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 1 of the audit-sweep refactor. Five low-risk, mechanical refactors bundled into one squashable commit. Version bumped 8.0.32 -> 8.0.33.
Per-item checklist
1. Banned vocabulary
firehoseremoved from source doc comments,README.md, andROADMAP.md. Replaced withfull-stream/full-type. CHANGELOG history intentionally untouched.crates/thetadatadx/src/unified.rs(3 sites)crates/thetadatadx/src/fpss/mod.rs(2 sites)README.md,ROADMAP.md(4 sites total)2. Internal version refs removed from source comments (
v8.0.10,v7.2.0,v8.0.3,v8.0.2,v6.0.1+). Semantic content preserved.crates/thetadatadx/src/wire_semantics.rs:9crates/thetadatadx/src/decode.rs:1734crates/tdbe/benches/bench_tick.rs:9crates/thetadatadx/build_support/ticks/python_arrow.rs:57crates/thetadatadx/build_support/endpoints/render/python.rs:13,207,2213.
ParsedRight::from_wire_bytewired at 4 magic-number sites incrates/tdbe/src/types/tick.rs.pub use crate::right::ParsedRight;added at the call site.is_call/is_putmacro impls (lines 31, 36)OptionContractimpls (lines 103, 108)tdbetests pass.4.
crates/json_canonfolded intotdbe::json_canon. Workspace member removed;sonic-rsdep relocated totdbe; all CLI / MCP / server callers updated.5. Seven ADRs added under
docs/architecture/:Version bump output
python3 scripts/check_version_sync.py->version sync: ok.Final scrubs
rg -i firehose crates/ README.md ROADMAP.md-> zero hitsrg "from_wire_byte" crates/tdbe/src/types/tick.rs-> 4 hits (the 4 wired sites)crates/json_canon/-> directory removed, no workspace memberls docs/architecture/ADR-00*.md | wc -l-> 7Local gate
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacecargo deny checkcargo run -p thetadatadx --bin generate_sdk_surfaces --features config-file -- --checkcargo check --manifest-path tools/mcp/Cargo.toml --lockedcargo clippy --manifest-path tools/mcp/Cargo.toml --all-targets -- -D warningscargo test --manifest-path tools/mcp/Cargo.toml --no-runcargo check --manifest-path tools/server/Cargo.toml --lockedcargo check --manifest-path sdks/python/Cargo.toml --lockedcargo check --manifest-path sdks/typescript/Cargo.toml --lockedpython3 scripts/check_version_sync.pyOut of scope (deferred to follow-up dispatch)
The coordinator expanded scope mid-flight to bundle Wave 2 + Wave 3 + Wave 4 (breaking 9.0.0 cut) into the same PR. That expansion is genuinely a multi-session effort (god-file splits with import-fixup across the workspace, build.rs codegen migration for 2.7K-LoC condition tables, ArcSwap state-machine introduction with new transition tests, breaking surface removals cascading through ffi/python/typescript bindings). Per the coordinator's own guidance ("If this scope is genuinely too much for one session, complete what you can cleanly and surface what's left in the PR body"), this PR ships Wave 1 only as 8.0.33 and surfaces the remainder for a follow-up
refactor/9.0.0-mega-cutdispatch:tdbe::timeEastern-time lift;tdbe/build.rsconditions codegen from TOML.SubscriptionTier(2^tier semaphore);ArcSwap<StreamingSlot>3-field collapse; layout moves undermdds/;unified.rs->client.rs;frames/andtypes/generated/regrouping; LOW chores 3.1, 3.2, 3.5, 3.9, 3.10.contract_map/contract_lookupremoval; B2pub mod proto->pub(crate); B3connection/framing/ring/dispatcher->pub(crate); B4FpssConnectArgs; B5Contract::optionIntoOptionSpeccollapse.DO NOT MERGE. DO NOT TAG.
Refs #500.