Skip to content

fix(docs): correct the C from_file snippet and clean stale surface references#796

Merged
userFRM merged 1 commit into
mainfrom
fix/final-pre-tag-cleanup
Jun 15, 2026
Merged

fix(docs): correct the C from_file snippet and clean stale surface references#796
userFRM merged 1 commit into
mainfrom
fix/final-pre-tag-cleanup

Conversation

@userFRM

@userFRM userFRM commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Closes the three findings from the final pre-tag audit of the v13 release candidate.

  • The C migration snippet called thetadatadx_client_connect_from_file("creds.txt", NULL), but the C ABI requires a non-null config handle (thetadatadx_last_error() returns "config handle is null" otherwise). It now passes thetadatadx_config_production(), matching the other C before/after blocks in the guide.
  • The bug-report issue template referenced the removed ThetaDataDxClient::stock_history_eod / ::subscribe names; it now points at client.historical.stock_history_eod / client.stream.subscribe.
  • The source-docs framing CI job and step names dropped the "reverse-engineering" wording so the public Actions UI carries neutral labels. The job is not a required status check, so the rename does not affect branch protection.

🤖 Generated with Claude Code

…ferences

The C migration example passed a null config to thetadatadx_client_connect_from_file, but the C ABI requires a non-null config handle and hard-fails otherwise, so the snippet was a copy-paste failure; pass a production config handle as the other before/after C blocks do.

Update the bug-report template's example method names to the role-namespaced client surface, and rename the source-docs framing CI job and step so the public Actions UI carries neutral wording.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@userFRM userFRM merged commit f281565 into main Jun 15, 2026
47 checks passed
@userFRM userFRM deleted the fix/final-pre-tag-cleanup branch June 15, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants