feat all: Breaking: remove autostart_at_base_component default

This PR introduces breaking API changes:

1. Removes a default from `autostart_at_base_component` parameter of the `DistLockComponentBase` .ctor.
2. Removes `AutostartDistlock::kNo` enum member and introduces a new `DistLockComponentBase` .ctor accepting `DisableAutostartAtBase` tag parameter that behaves like the original .ctor with `autostart_at_base_component == AutostartDistlock::kNo`.

Thus all descendants of `DistLockComponentBase` should either pass `AutostartDistlock::kYes` or `DisableAutostartAtBase{}` to the `DistLockComponentBase`'s .ctor.

`DisableAutostartAtBase{}`preserves the original behaviour (with manual distlock startup/shutdown management) while `AutostartDistlock::kYes` delegates a distlock startup/shutdown to the framework.

</section>

Later we are going to completely remove the `autostart_at_base_component`parameter and enable automatic management of distlock stratup/shutdown by default.
commit_hash:35cd7bf4a4258b8047b1e7768c04ddc9669c5964

Author: lexeyo

postgresql/include/userver/storages/postgres/dist_lock_component_base.hpp

@@ -63,12 +63,21 @@ namespace storages::postgres {
 /// @see @ref scripts/docs/en/userver/periodics.md
 class DistLockComponentBase : public components::ComponentBase {
 public:
-    enum class AutostartDistlock : bool { kNo = false, kYes = true };
+    // This enum is going to be completely removed.
+    enum class AutostartDistlock : bool { kYes = true };
+
+    struct DisableAutostartAtBase {};
+
+    DistLockComponentBase(
+        const components::ComponentConfig& component_config,
+        const components::ComponentContext& component_context,
+        AutostartDistlock autostart_at_base_component
+    );
 
     DistLockComponentBase(
-        const components::ComponentConfig&,
-        const components::ComponentContext&,
-        AutostartDistlock autostart_at_base_component = AutostartDistlock::kNo
+        const components::ComponentConfig& component_config,
+        const components::ComponentContext& component_context,
+        DisableAutostartAtBase
     );
 
     ~DistLockComponentBase() override;
@@ -119,10 +128,10 @@ class DistLockComponentBase : public components::ComponentBase {
     /// Override this function to provide custom testsuite handler.
     virtual void DoWorkTestsuite() { DoWork(); }
 
-    /// Must be called in ctr
+    /// Should be called in .ctor of a derived class if autostart at base .ctor is disabled.
     void AutostartDistLock();
 
-    /// Must be called in dtr
+    /// Should be called in .dtor of a derived class if autostart at base .ctor is disabled.
     void StopDistLock();
 
     /// Check this method when going for the next independent processing
@@ -131,6 +140,14 @@ class DistLockComponentBase : public components::ComponentBase {
     bool IsCancelAdvised() const;
 
 private:
+    enum class AutostartDistlockInternal : bool { kNo = false, kYes = true };
+
+    DistLockComponentBase(
+        const components::ComponentConfig& component_config,
+        const components::ComponentContext& component_context,
+        AutostartDistlockInternal enable_autostart_at_base
+    );
+
     bool ShouldRunOnHost(const dynamic_config::Snapshot& config) const;
     void OnConfigUpdate(const dynamic_config::Diff& diff);
 
@@ -140,8 +157,7 @@ class DistLockComponentBase : public components::ComponentBase {
     std::unique_ptr<dist_lock::DistLockedWorker> worker_;
     bool autostart_;
     bool testsuite_enabled_{false};
-    // temporary parameter, will be removed when all AutostartDistlock calls will be removed from the ctors
-    AutostartDistlock autostart_at_base_component_{AutostartDistlock::kNo};
+    AutostartDistlockInternal enable_autostart_at_base_;
     dist_lock::DistLockSettings default_settings_;
 
     concurrent::AsyncEventSubscriberScope subscription_token_;

postgresql/src/storages/postgres/dist_lock_component_base.cpp

@@ -24,13 +24,13 @@ namespace storages::postgres {
 DistLockComponentBase::DistLockComponentBase(
     const components::ComponentConfig& component_config,
     const components::ComponentContext& component_context,
-    AutostartDistlock autostart_at_base_component
+    AutostartDistlockInternal enable_autostart_at_base
 )
     : components::ComponentBase(component_config, component_context),
       config_(component_context.FindComponent<components::DynamicConfig>().GetSource()),
       name_(component_config.Name()),
       real_host_name_(hostinfo::blocking::GetRealHostName()),
-      autostart_at_base_component_(autostart_at_base_component)
+      enable_autostart_at_base_(enable_autostart_at_base)
 {
     auto shard_number = component_config["shard-number"].As<size_t>(components::Postgres::kDefaultShardNumber);
     auto cluster =
@@ -86,7 +86,7 @@ DistLockComponentBase::DistLockComponentBase(
         {{"distlock_name", component_config.Name()}}
     );
 
-    const bool autostart_enabled = autostart_at_base_component_ == AutostartDistlock::kYes;
+    const bool autostart_enabled = enable_autostart_at_base_ == AutostartDistlockInternal::kYes;
     if (component_config["testsuite-support"].As<bool>(autostart_enabled)) {
         auto& testsuite_tasks = testsuite::GetTestsuiteTasks(component_context);
 
@@ -107,14 +107,28 @@ DistLockComponentBase::DistLockComponentBase(
     }
 }
 
+DistLockComponentBase::DistLockComponentBase(
+    const components::ComponentConfig& component_config,
+    const components::ComponentContext& component_context,
+    AutostartDistlock
+)
+    : storages::postgres::DistLockComponentBase(component_config, component_context, AutostartDistlockInternal::kYes) {}
+
+DistLockComponentBase::DistLockComponentBase(
+    const components::ComponentConfig& component_config,
+    const components::ComponentContext& component_context,
+    DisableAutostartAtBase
+)
+    : storages::postgres::DistLockComponentBase(component_config, component_context, AutostartDistlockInternal::kNo) {}
+
 DistLockComponentBase::~DistLockComponentBase() { subscription_token_.Unsubscribe(); }
 
 dist_lock::DistLockedWorker& DistLockComponentBase::GetWorker() { return *worker_; }
 
 bool DistLockComponentBase::OwnsLock() const noexcept { return worker_->OwnsLock() || testsuite_enabled_; }
 
 void DistLockComponentBase::AutostartDistLock() {
-    UASSERT(autostart_at_base_component_ == AutostartDistlock::kNo);
+    UASSERT(enable_autostart_at_base_ == AutostartDistlockInternal::kNo);
 
     if (testsuite_enabled_) {
         return;