feat: Add URL encoding for S3 object keys#1164
Closed
Tnirpps wants to merge 1 commit intouserver-framework:developfrom
Closed
feat: Add URL encoding for S3 object keys#1164Tnirpps wants to merge 1 commit intouserver-framework:developfrom
Tnirpps wants to merge 1 commit intouserver-framework:developfrom
Conversation
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Apr 6, 2026
# S3 URL Encoding Fix ## Problem S3 API methods (`GetObject`, `PutObject`, etc.) failed with object keys containing special characters (spaces, Cyrillic, etc.) because they weren't being URL-encoded. `Bad URL, curl error: malformed input, url: https://mybucket.s3-some-site.awsornot.com/path/to/object with : spaces` ## Solution Added two functions for proper S3 object key encoding, compatible with AWS SDK behavior: - **`UrlEncodePathSegment()`** - encodes a single path segment, preserving RFC 3986 unreserved chars (`-`, `_`, `.`, `~`) and S3-safe chars (`$`, `&`, `,`, `:`, `=`, `@`) - **`EncodeS3Key()`** - encodes S3 object key, preserving `/` as path separators Implementation follows AWS SDK approach: [aws-sdk-cpp/URI.cpp](https://github.com/aws/aws-sdk-cpp/blob/master/aws-cpp-sdk-core/source/http/URI.cpp#L54-L60) **Examples:** ```cpp EncodeS3Key("folder/file with spaces.txt") // → "folder/file%20with%20spaces.txt" EncodeS3Key("folder/файл.txt") // → "folder/%D1%84%D0%B0%D0%B9%D0%BB.txt" ``` ## Changes - **universal/http/url.hpp, url.cpp**: New encoding functions - **universal/http/url_test.cpp**: new tests - **libraries/s3api/s3api_methods.cpp**: Apply `EncodeS3Key()` to all S3 methods Tests: протестировано CI --- Pull Request resolved: #1164 commit_hash:04d0362e7803510b3923ebcfa43f9284b635a57c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 URL Encoding Fix
Problem
S3 API methods (
GetObject,PutObject, etc.) failed with object keys containing special characters (spaces, Cyrillic, etc.) because they weren't being URL-encoded.Bad URL, curl error: malformed input, url: https://mybucket.s3-some-site.awsornot.com/path/to/object with : spacesSolution
Added two functions for proper S3 object key encoding, compatible with AWS SDK behavior:
UrlEncodePathSegment()- encodes a single path segment, preserving RFC 3986 unreserved chars (-,_,.,~) and S3-safe chars ($,&,,,:,=,@)EncodeS3Key()- encodes S3 object key, preserving/as path separatorsImplementation follows AWS SDK approach: aws-sdk-cpp/URI.cpp
Examples:
Changes
EncodeS3Key()to all S3 methods