Revert "Artificially fail tests to test reporting."

This reverts commit 622cea0.

Author: toinehartman

.github/workflows/build.yaml

@@ -50,7 +50,7 @@ jobs:
     strategy:
       matrix:
         os: [ubicloud-standard-4, windows-latest, macos-latest]
-      fail-fast: false
+      fail-fast: true
     env:
       CODE_VERSION: "1.100.0"
     runs-on:  ${{ matrix.os }}
@@ -96,7 +96,7 @@ jobs:
           DELAY_FACTOR: 10
           RASCAL_LSP_DEV_DEPLOY: true
           _JAVA_OPTIONS: '-Xmx5G'
-        run: npx extest setup-and-run out/test/vscode-suite/dsl.test.js --storage uitests
+        run: npx extest setup-and-run out/test/vscode-suite/*.test.js --storage uitests
 
       - name: "UI test (mac)"
         shell: bash
@@ -106,7 +106,7 @@ jobs:
           DELAY_FACTOR: 15
           RASCAL_LSP_DEV_DEPLOY: true
           _JAVA_OPTIONS: '-Xmx5G'
-        run: npx extest setup-and-run out/test/vscode-suite/dsl.test.js --storage uitests
+        run: npx extest setup-and-run out/test/vscode-suite/*.test.js --storage uitests
 
       - name: "UI test (ubuntu)"
         shell: bash
@@ -118,7 +118,7 @@ jobs:
           _JAVA_OPTIONS: '-Xmx5G' # we have 16gb of memory, make sure LSP, REPL & DSL-LSP can start
         run: |
           sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 # workaround for issue with Ubuntu 24.04 https://github.com/redhat-developer/vscode-extension-tester/blob/main/KNOWN_ISSUES.md#openresources-not-working-with-apparmor-2404
-          xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npx extest setup-and-run out/test/vscode-suite/dsl.test.js --storage uitests
+          xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npx extest setup-and-run out/test/vscode-suite/*.test.js --storage uitests
 
       - name: Upload Screenshots
         uses: actions/upload-artifact@v7

rascal-vscode-extension/src/test/vscode-suite/dsl.test.ts

@@ -32,7 +32,6 @@ import { expect } from 'chai';
 import * as fs from 'fs/promises';
 import { Suite } from 'mocha';
 import * as path from 'path/posix';
-import { fail } from 'assert';
 
 function parameterizedDescribe(body: (this: Suite, errorRecovery: boolean) => void) {
     describe('DSL', function() { body.apply(this, [false]); });
@@ -104,9 +103,28 @@ parameterizedDescribe(function (errorRecovery: boolean) {
         await protectedFiles.restore();
     });
 
-    it.only("has highlighting and parse errors", async function () {
-        fail("Artificial failure");
-    });
+    it("has highlighting and parse errors", async function () {
+        await ignoreFails(new Workbench().getEditorView().closeAllEditors());
+        const editor = await ide.openModule(TestWorkspace.picoFile);
+        const isPicoLoading = ide.statusContains("Pico");
+        // we might miss this event, but we wait for it to show up
+        await ignoreFails(driver.wait(isPicoLoading, Delays.normal, "Pico parser generator should have started"));
+        // now wait for the Pico parser generator to disappear
+        await driver.wait(async () => !(await isPicoLoading()), Delays.verySlow, "Pico parser generator should have finished", 100);
+        await ide.hasSyntaxHighlighting(editor, Delays.slow);
+        console.log("We got syntax highlighting");
+        try {
+            await editor.setTextAtLine(10, "b := ;");
+            await ide.hasErrorSquiggly(editor, Delays.slow);
+        } catch (e) {
+            console.log(`Failed to trigger parse error: ${e}`);
+            if (e instanceof Error) {
+                console.log(e.stack);
+            }
+        } finally {
+            await ide.revertOpenChanges();
+        }
+    }).retries(2);
 
     it("has highlighting and parse errors for second extension", async function () {
         const editor = await ide.openModule(TestWorkspace.picoNewFile);