Refresh editors using LSP instead of close+open.

Refreshing by toggling the language (causing a close+open) might lead to
requests coming in while the file is closed, therefore causing confusing
errors.

Author: toinehartman

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

@@ -945,8 +945,6 @@ public synchronized void registerLanguage(LanguageParameter lang) {
             this.registeredExtensions.put(extension, lang.getName());
         }
 
-        updateCapabilities();
-
         // If we opened any files with this extension before, now associate them with contributions
         var extensions = Arrays.asList(lang.getExtensions());
         for (var f : getOpenFiles()) {
@@ -955,13 +953,30 @@ public synchronized void registerLanguage(LanguageParameter lang) {
                 refreshFileState(f);
             }
         }
+
+        // Do this last, after the parser for open editors has been updated,
+        // since this might trigger new requests on the editor contents.
+        updateCapabilities();
+    }
+
+    private CompletableFuture<Void> refreshEditors() {
+        return CompletableFutureUtils.reduce(List.of(
+            availableClient().refreshCodeLenses(),
+            availableClient().refreshDiagnostics(),
+            availableClient().refreshFoldingRanges(),
+            availableClient().refreshInlayHints(),
+            availableClient().refreshInlineValues(),
+            availableClient().refreshSemanticTokens()
+        ), (v1, v2) -> null);
     }
 
     private synchronized CompletableFuture<Void> updateCapabilities() {
         // `CapabilityRegistration::update` should never be called asynchronously, since that might re-order incoming updates.
         // Since `registerLanguage` is called from a single-threaded pool, calling it here is safe.
         // Note: `CapabilityRegistration::update` returns a void future, which we do not have to wait on.
-        return availableCapabilities().update(buildLanguageParams());
+        return availableCapabilities()
+            .update(buildLanguageParams())
+            .thenCompose(v -> refreshEditors());
     }
 
     /**

rascal-vscode-extension/src/lsp/ParameterizedLanguageServer.ts

@@ -102,8 +102,7 @@ export class ParameterizedLanguageServer implements vscode.Disposable {
             for (const doc of vscode.workspace.textDocuments) {
                 const ext = path.extname(doc.uri.path);
                 if (ext !== "" && lang.extensions.includes(ext.substring(1))) {
-                    // (Re)set the language ID to re-trigger contribution requests
-                    await vscode.languages.setTextDocumentLanguage(doc, "plaintext");
+                    // Associate open editors with the given extensions with this language server
                     await vscode.languages.setTextDocumentLanguage(doc, this.languageId);
                 }
             }