Merge pull request #1017 from usethesource/fix/register-precompiled-parser-crash

Always return a value from (unprovided) contributions

Author: DavyLandman

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ILanguageContributions.java

@@ -72,22 +72,22 @@ public interface ILanguageContributions {
     public CompletableFuture<IList> parseCodeActions(String command);
     public CompletableFuture<IConstructor> parseCallHierarchyData(String data);
 
-    public CompletableFuture<Boolean> hasAnalysis();
-    public CompletableFuture<Boolean> hasBuild();
-    public CompletableFuture<Boolean> hasDocumentSymbol();
-    public CompletableFuture<Boolean> hasCodeLens();
-    public CompletableFuture<Boolean> hasInlayHint();
-    public CompletableFuture<Boolean> hasRename();
-    public CompletableFuture<Boolean> hasExecution();
-    public CompletableFuture<Boolean> hasHover();
-    public CompletableFuture<Boolean> hasDefinition();
-    public CompletableFuture<Boolean> hasReferences();
-    public CompletableFuture<Boolean> hasImplementation();
-    public CompletableFuture<Boolean> hasCodeAction();
-    public CompletableFuture<Boolean> hasDidRenameFiles();
-    public CompletableFuture<Boolean> hasSelectionRange();
-    public CompletableFuture<Boolean> hasCallHierarchy();
-    public CompletableFuture<Boolean> hasCompletion();
+    public CompletableFuture<Boolean> providesAnalysis();
+    public CompletableFuture<Boolean> providesBuild();
+    public CompletableFuture<Boolean> providesDocumentSymbol();
+    public CompletableFuture<Boolean> providesCodeLens();
+    public CompletableFuture<Boolean> providesInlayHint();
+    public CompletableFuture<Boolean> providesRename();
+    public CompletableFuture<Boolean> providesExecution();
+    public CompletableFuture<Boolean> providesHover();
+    public CompletableFuture<Boolean> providesDefinition();
+    public CompletableFuture<Boolean> providesReferences();
+    public CompletableFuture<Boolean> providesImplementation();
+    public CompletableFuture<Boolean> providesCodeAction();
+    public CompletableFuture<Boolean> providesDidRenameFiles();
+    public CompletableFuture<Boolean> providesSelectionRange();
+    public CompletableFuture<Boolean> providesCallHierarchy();
+    public CompletableFuture<Boolean> providesCompletion();
 
     public CompletableFuture<Boolean> specialCaseHighlighting();
 

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/InterpretedLanguageContributions.java

@@ -103,22 +103,22 @@ public class InterpretedLanguageContributions implements ILanguageContributions
     private final CompletableFuture<@Nullable IFunction> completion;
     private final CompletableFuture<IList> completionTriggerCharacters;
 
-    private final CompletableFuture<Boolean> hasAnalysis;
-    private final CompletableFuture<Boolean> hasBuild;
-    private final CompletableFuture<Boolean> hasDocumentSymbol;
-    private final CompletableFuture<Boolean> hasCodeLens;
-    private final CompletableFuture<Boolean> hasInlayHint;
-    private final CompletableFuture<Boolean> hasExecution;
-    private final CompletableFuture<Boolean> hasHover;
-    private final CompletableFuture<Boolean> hasDefinition;
-    private final CompletableFuture<Boolean> hasReferences;
-    private final CompletableFuture<Boolean> hasImplementation;
-    private final CompletableFuture<Boolean> hasCodeAction;
-    private final CompletableFuture<Boolean> hasRename;
-    private final CompletableFuture<Boolean> hasDidRenameFiles;
-    private final CompletableFuture<Boolean> hasSelectionRange;
-    private final CompletableFuture<Boolean> hasCallHierarchy;
-    private final CompletableFuture<Boolean> hasCompletion;
+    private final CompletableFuture<Boolean> providesAnalysis;
+    private final CompletableFuture<Boolean> providesBuild;
+    private final CompletableFuture<Boolean> providesDocumentSymbol;
+    private final CompletableFuture<Boolean> providesCodeLens;
+    private final CompletableFuture<Boolean> providesInlayHint;
+    private final CompletableFuture<Boolean> providesExecution;
+    private final CompletableFuture<Boolean> providesHover;
+    private final CompletableFuture<Boolean> providesDefinition;
+    private final CompletableFuture<Boolean> providesReferences;
+    private final CompletableFuture<Boolean> providesImplementation;
+    private final CompletableFuture<Boolean> providesCodeAction;
+    private final CompletableFuture<Boolean> providesRename;
+    private final CompletableFuture<Boolean> providesDidRenameFiles;
+    private final CompletableFuture<Boolean> providesSelectionRange;
+    private final CompletableFuture<Boolean> providesCallHierarchy;
+    private final CompletableFuture<Boolean> providesCompletion;
 
     private final CompletableFuture<Boolean> specialCaseHighlighting;
 
@@ -171,22 +171,22 @@ public InterpretedLanguageContributions(LanguageParameter lang, IBaseTextDocumen
             this.completionTriggerCharacters = getContributionParameter(contributions, LanguageContributions.COMPLETION, LanguageContributions.COMPLETION_TRIGGER_CHARACTERS, VF.list(), IList.class);
 
             // assign boolean properties once instead of wasting futures all the time
-            this.hasAnalysis = nonNull(this.analysis);
-            this.hasBuild = nonNull(this.build);
-            this.hasDocumentSymbol = nonNull(this.documentSymbol);
-            this.hasCodeLens = nonNull(this.codeLens);
-            this.hasInlayHint = nonNull(this.inlayHint);
-            this.hasExecution = nonNull(this.execution);
-            this.hasHover = nonNull(this.hover);
-            this.hasDefinition = nonNull(this.definition);
-            this.hasReferences = nonNull(this.references);
-            this.hasImplementation = nonNull(this.implementation);
-            this.hasCodeAction = nonNull(this.codeAction);
-            this.hasRename = nonNull(this.rename);
-            this.hasDidRenameFiles = nonNull(this.didRenameFiles);
-            this.hasSelectionRange = nonNull(this.selectionRange);
-            this.hasCallHierarchy = nonNull(this.prepareCallHierarchy);
-            this.hasCompletion = nonNull(this.completion);
+            this.providesAnalysis = nonNull(this.analysis);
+            this.providesBuild = nonNull(this.build);
+            this.providesDocumentSymbol = nonNull(this.documentSymbol);
+            this.providesCodeLens = nonNull(this.codeLens);
+            this.providesInlayHint = nonNull(this.inlayHint);
+            this.providesExecution = nonNull(this.execution);
+            this.providesHover = nonNull(this.hover);
+            this.providesDefinition = nonNull(this.definition);
+            this.providesReferences = nonNull(this.references);
+            this.providesImplementation = nonNull(this.implementation);
+            this.providesCodeAction = nonNull(this.codeAction);
+            this.providesRename = nonNull(this.rename);
+            this.providesDidRenameFiles = nonNull(this.didRenameFiles);
+            this.providesSelectionRange = nonNull(this.selectionRange);
+            this.providesCallHierarchy = nonNull(this.prepareCallHierarchy);
+            this.providesCompletion = nonNull(this.completion);
 
             this.specialCaseHighlighting = getContributionParameter(contributions,
                 LanguageContributions.PARSING,
@@ -342,7 +342,6 @@ private CompletableFuture<IConstructor> parseCommand(String command) {
                     return contrib;
                 }
             }
-            logger.debug("No {} defined", cons);
             return null;
         });
     }
@@ -420,7 +419,7 @@ public InterruptibleFuture<ISourceLocation> prepareRename(IList focus) {
     @Override
     public InterruptibleFuture<ITuple> rename(IList focus, String newName) {
         debug(LanguageContributions.RENAME_SERVICE, newName, focus.isEmpty() ? "" : focus.get(0));
-        return execFunction(LanguageContributions.RENAME_SERVICE, rename, VF.tuple(VF.list(), VF.list()), focus, VF.string(newName));
+        return execFunction(LanguageContributions.RENAME_SERVICE, rename, VF.tuple(VF.list(), VF.set()), focus, VF.string(newName));
     }
 
     @Override
@@ -496,82 +495,82 @@ private void debug(String name, Object param1, Object param2) {
     }
 
     @Override
-    public CompletableFuture<Boolean> hasDefinition() {
-        return hasDefinition;
+    public CompletableFuture<Boolean> providesDefinition() {
+        return providesDefinition;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasReferences() {
-        return hasReferences;
+    public CompletableFuture<Boolean> providesReferences() {
+        return providesReferences;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasImplementation() {
-        return hasImplementation;
+    public CompletableFuture<Boolean> providesImplementation() {
+        return providesImplementation;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasHover() {
-        return hasHover;
+    public CompletableFuture<Boolean> providesHover() {
+        return providesHover;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasExecution() {
-        return hasExecution;
+    public CompletableFuture<Boolean> providesExecution() {
+        return providesExecution;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasInlayHint() {
-        return hasInlayHint;
+    public CompletableFuture<Boolean> providesInlayHint() {
+        return providesInlayHint;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasRename() {
-        return hasRename;
+    public CompletableFuture<Boolean> providesRename() {
+        return providesRename;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasDidRenameFiles() {
-        return hasDidRenameFiles;
+    public CompletableFuture<Boolean> providesDidRenameFiles() {
+        return providesDidRenameFiles;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasCodeLens() {
-        return hasCodeLens;
+    public CompletableFuture<Boolean> providesCodeLens() {
+        return providesCodeLens;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasDocumentSymbol() {
-        return hasDocumentSymbol;
+    public CompletableFuture<Boolean> providesDocumentSymbol() {
+        return providesDocumentSymbol;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasCodeAction() {
-        return hasCodeAction;
+    public CompletableFuture<Boolean> providesCodeAction() {
+        return providesCodeAction;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasSelectionRange() {
-        return hasSelectionRange;
+    public CompletableFuture<Boolean> providesSelectionRange() {
+        return providesSelectionRange;
     }
 
-    public CompletableFuture<Boolean> hasCallHierarchy() {
-        return hasCallHierarchy;
+    public CompletableFuture<Boolean> providesCallHierarchy() {
+        return providesCallHierarchy;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasCompletion() {
-        return hasCompletion;
+    public CompletableFuture<Boolean> providesCompletion() {
+        return providesCompletion;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasAnalysis() {
-        return hasAnalysis;
+    public CompletableFuture<Boolean> providesAnalysis() {
+        return providesAnalysis;
     }
 
     @Override
-    public CompletableFuture<Boolean> hasBuild() {
-        return hasBuild;
+    public CompletableFuture<Boolean> providesBuild() {
+        return providesBuild;
     }
 
     @Override