Merge pull request #687 from usethesource/fix/end-all-progress-bars

Fix stale evaluation progress bars

Author: toinehartman

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/EvaluatorUtil.java

@@ -114,20 +114,22 @@ public static <T> InterruptibleFuture<T> runEvaluator(String task, CompletableFu
 
                 actualEval.jobStart(task);
                 synchronized (actualEval) {
+                    boolean jobSuccess = false;
                     try {
                         runningEvaluator.set(actualEval);
                         if (interrupted.get()) {
                             return defaultResult;
                         }
                         T result = call.apply(actualEval);
-                        actualEval.jobEnd(task, true);
+                        jobSuccess = true;
                         return result;
                     } catch (InterruptException e) {
                         // Since the interrupt is not caught by try-catch in Rascal, any jobs started from Rascal with the same name as this task will be 'nested', and might lead to stale progress bars.
                         // Here, we remove all (nested) jobs.
                         actualEval.endAllJobs();
                         return defaultResult;
                     } finally {
+                        actualEval.jobEnd(task, jobSuccess);
                         if (monitor instanceof RascalLSPMonitor) {
                             ((RascalLSPMonitor) monitor).unregisterActiveFuture(task);
                         }