Classpath contains multiple versions of a dependency

[toinehartman]

Describe the bug

Type-checking bird fails

To Reproduce

Steps to reproduce the behavior:

1. Clone https://github.com/swat-engineering/bird and open the workspace
2. Remove all TPLs (for example by running find . -iname *.tpl -exec rm -v {} \;
3. Open bird-ide\src\main\rascal\lang\bird\LanguageServer.rsc
4. Ctrl+S to initiate a type-check
5. Observe the error "Module util::LanguageServer not found" (and missing declarations from this module)

Expected behavior
No missing import, since library modules from rascal-lsp should be on the path.

Desktop (please complete the following information):

• Context: VS Code extension
• Rascal Version: VS Code extension 0.13.0

Additional context

Path config:

projectRoot:|file:///c:/Users/toine/swat/projects/bird/bird-ide|
srcs:       [|file:///c:/Users/toine/swat/projects/bird/bird-ide/src/main/rascal|]
ignores:    []
libs:       [|jar+file:///C:/Users/toine/.vscode/extensions/usethesource.rascalmpl-0.13.0/assets/jars/rascal.jar!/|,|target://bird-core|,|mvn://org.rascalmpl--typepal--0.15.5|,|mvn://junit--junit--4.13.1|,|mvn://org.hamcrest--hamcrest-core--1.3|,|file:///c:/Users/toine/swat/projects/bird/bird-core/target/classes|,|file:///C:/Users/toine/.vscode/extensions/usethesource.rascalmpl-0.13.0/assets/jars/rascal-lsp.jar|,|jar+file:///C:/Users/toine/.vscode/extensions/usethesource.rascalmpl-0.13.0/assets/jars/rascal-lsp.jar!/|,|mvn://org.rascalmpl--typepal--0.15.2-RC16|]
bin:        |file:///c:/Users/toine/swat/projects/bird/bird-ide/target/classes|
resources:  []
messages:   []

[toinehartman]

One thing that stands out is the presence of |mvn://org.rascalmpl--typepal--0.15.2-RC16| in the path config (next to 0.15.5).

mvn dependency:tree does not include it:

$ mvn dependency:tree -Dverbose=true
...
[INFO] --- dependency:3.8.0:tree (default-cli) @ bird-ide ---
[INFO] engineering.swat:bird-ide:jar:2.0.0-SNAPSHOT
[INFO] +- org.rascalmpl:rascal-lsp:jar:2.22.0:compile
[INFO] |  \- org.rascalmpl:rascal:jar:0.41.2:compile (version managed from 0.41.2)
[INFO] \- engineering.swat:bird-core:jar:2.0.0-SNAPSHOT:compile
[INFO]    +- (org.rascalmpl:rascal:jar:0.41.2:compile - version managed from 0.41.2; omitted for duplicate)
[INFO]    +- (org.rascalmpl:rascal-lsp:jar:2.22.0:compile - version managed from 2.22.0; omitted for duplicate)
[INFO]    \- org.rascalmpl:typepal:jar:0.15.5:compile (version managed from 0.15.5)
[INFO]       \- junit:junit:jar:4.13.1:test (version managed from 4.13.1; scope managed from compile)
[INFO]          \- org.hamcrest:hamcrest-core:jar:1.3:test
...

Rascal already returns RC version in the classpath here, so it seems likely this is caused by a bug in our Maven resolution.

https://github.com/usethesource/rascal/blob/3ba2f3496e1adb0ef9f09c4f336079aed452f214/src/org/rascalmpl/library/util/PathConfig.java#L950

I tried to encapsulate this in a JUnit in test for the Maven parser but that's not easy. I can reproduce the exact same behaviour by pointing to bird-ide/pom.xml here.

It seems like the Maven parser resolves the unversioned typepal dependency in bird-core to the RC instead of to the parent POM's 0.15.5. @PieterOlivier Since you are familiar with the Maven parser; any clue what's going on here?