Replace common get-or-initialize pattern with utility function#1004
Merged
DavyLandman merged 2 commits intomainfrom Mar 5, 2026
Merged
Replace common get-or-initialize pattern with utility function#1004DavyLandman merged 2 commits intomainfrom
DavyLandman merged 2 commits intomainfrom
Conversation
toinehartman
force-pushed
the
fix/init-and-get-capabilities
branch
from
0baac7b to
d9835d9
Compare
DavyLandman
approved these changes
Mar 4, 2026
| workspace.setFileOperations(fileOps); | ||
| } | ||
| return fileOps; | ||
| var workspace = Nullables.initAndGet(caps, ServerCapabilities::getWorkspace, ServerCapabilities::setWorkspace, WorkspaceServerCapabilities::new); |
Member
There was a problem hiding this comment.
it's a bit strange that the function is called initAndGet and it also does a set?
Member
Author
There was a problem hiding this comment.
Renamed to ensureNonNullAndGet and explicitly mentioned the set operation in the documentation as well.
toinehartman
force-pushed
the
fix/init-and-get-capabilities
branch
from
ef5b8da to
a221501
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces a common pattern with a utility function.
This is the setting counterpart of #1001.