Rename independent of util::LanguageServer#1012
Merged
toinehartman merged 9 commits intomainfrom Mar 11, 2026
Merged
Conversation
DavyLandman
reviewed
Mar 11, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
I like the idea, but have some small remarks.
|
toinehartman
added a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from needing any
@javaClass-annotated functions from LSP during renaming, simplifying testing in usethesource/rascal-core-big-tests#5. This also helps with separating the renaming implementation from the language server interface and cleaning uputil::LanguageServer.